Remove unused method

# Conflicts: # maven-api-impl/src/main/java/org/apache/maven/internal/impl/model/DefaultModelValidator.java
apache · Sep 30, 2024 · 7ced2ce · 7ced2ce
1 parent 7a50bb3
commit 7ced2ce
Showing 1 changed file with 1 addition and 32 deletions.
diff --git a/maven-api-impl/src/main/java/org/apache/maven/internal/impl/model/DefaultModelValidator.java b/maven-api-impl/src/main/java/org/apache/maven/internal/impl/model/DefaultModelValidator.java
@@ -426,7 +426,7 @@ public void validateFileModel(
             validateStringNoExpression("artifactId", problems, Severity.WARNING, Version.V20, m.getArtifactId(), m);
             validateStringNotEmpty("artifactId", problems, Severity.FATAL, Version.V20, m.getArtifactId(), m);
 
-            validateVersionNoExpression("version", problems, Severity.WARNING, Version.V20, m.getVersion(), m);
+            validateStringNoExpression("version", problems, Severity.WARNING, Version.V20, m.getVersion(), m);
             if (parent == null) {
                 validateStringNotEmpty("version", problems, Severity.FATAL, Version.V20, m.getVersion(), m);
             }
@@ -1621,37 +1621,6 @@ private boolean validateStringNoExpression(
         return false;
     }
 
-    private boolean validateVersionNoExpression(
-            String fieldName,
-            ModelProblemCollector problems,
-            Severity severity,
-            Version version,
-            String string,
-            InputLocationTracker tracker) {
-        if (!hasExpression(string)) {
-            return true;
-        }
-
-        Matcher m = EXPRESSION_NAME_PATTERN.matcher(string.trim());
-        while (m.find()) {
-            String property = m.group(1);
-            if (!versionProcessor.isValidProperty(property)) {
-                addViolation(
-                        problems,
-                        severity,
-                        version,
-                        fieldName,
-                        null,
-                        "contains an expression but should be a constant.",
-                        tracker);
-
-                return false;
-            }
-        }
-
-        return true;
-    }
-
     private boolean hasExpression(String value) {
         return value != null && value.contains("${");
     }