Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to gradle 8.10 #13700

Merged
merged 14 commits into from
Aug 30, 2024
Merged

Upgrade to gradle 8.10 #13700

merged 14 commits into from
Aug 30, 2024

Conversation

dweiss
Copy link
Contributor

@dweiss dweiss commented Aug 29, 2024 •
edited
Loading

Fixes #13698.

I can't claim I've tested everything but most things seem to work.

@dweiss dweiss added this to the 10.0.0 milestone Aug 29, 2024
@dweiss dweiss self-assigned this Aug 29, 2024
ChrisHegarty
ChrisHegarty approved these changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@ChrisHegarty ChrisHegarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested a number of different JDKs, 21, 22, and 23-ea, with various different test specific properties and env variables, and all worked successfully. LGTM.

gradle/documentation/render-javadoc.gradle
@@ -32,7 +32,7 @@ allprojects {
missingdoclet "org.apache.lucene.tools:missing-doclet"
}

ext {
project.ext {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm.. it's odd that we have to do this, but I see that it's now necessary (why Gradle.. why!? ). This is reason that my previous local attempt to upgrade failed. Good that you have a fix.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think something within the scope changed and either groovy or gradle looks up a different 'ext' (extension) property now. I didn't bother trying to narrow it down but it is ugly.

@dweiss dweiss merged commit ea1441c into apache:main Aug 30, 2024
5 checks passed
@dweiss dweiss deleted the gradle-8.10 branch August 30, 2024 10:36
uschindler
uschindler reviewed Aug 30, 2024
View reviewed changes
Copy link
Contributor

@uschindler uschindler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. I will report issues in the seldomy executed tasks (like regenerate)

@uschindler
Copy link
Contributor

I also tested gradlew :lucene:core:regenerate and gradlew eclipse. Both work and the availability checks of toolkit autodownload works.

@dweiss
Copy link
Contributor Author

dweiss commented Aug 30, 2024

looks good. I will report issues in the seldomy executed tasks (like regenerate)

This is already sanity checked when you touch/ alter gradle files, along with other things.
https://github.com/apache/lucene/blob/main/.github/workflows/run-checks-gradle-upgrade.yml#L75-L86

Thanks for checking Eclipse, this is a bit manual.

asfgit pushed a commit that referenced this pull request Aug 30, 2024
@dweiss
Add jdk 23-ea to nightly smoke tester run. #13700
ce4f56e
dweiss added a commit to dweiss/lucene that referenced this pull request Sep 5, 2024
@dweiss
Upgrade to gradle 8.10 (apache#13700)
6b09dd3
@dweiss dweiss mentioned this pull request Sep 5, 2024
Merged
dweiss added a commit that referenced this pull request Sep 6, 2024
@dweiss
Upgrade to gradle 8.10 (branch 9x, backport of #13700) (#13729)
2a87e42 
* Upgrade to gradle 8.10 (#13700)

* Bump gradle version in check-environment.gradle.

* Bump groovy version to 4.0.22 so that regenerate works.

* Change groovy coordinates to org.apache.groovy.
@risdenk risdenk mentioned this pull request Nov 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uschindler uschindler uschindler left review comments

@ChrisHegarty ChrisHegarty ChrisHegarty approved these changes

Assignees

@dweiss dweiss

Labels
None yet
Projects
None yet
Milestone
10.0.0
Development

Successfully merging this pull request may close these issues.

Upgrade to gradle 8.10
3 participants
@dweiss @uschindler @ChrisHegarty