Cleanup TokenizedPhraseQueryNode code

[sabi0]

• harmonize implementations of the methods working with children
• save getChildren() in a variable and re-use it
• use more efficient isEmpty() instead of size() == 0
• fix a typo in the tag name: tokenized_t_phrase => tokenizedphrase
• remove unnecessary toString() call
• remove trailing comment referring to another class (copy paste? renaming that did not update the comment?)

[sabi0]

According to the setField(CharSequence) method below children are not necessarily FieldableNode.
I.e. this line might throw ClassCastException?

[stefanvodita]

I see your point. Maybe it's worth adding an assertion?

[sabi0]

I think the two methods should be aligned.
If one has an assert (assumes all the children are FieldableNode) then the other should do so too.
Of they both should silently ignore children of other types.

I would probably go with "silently ignore children of other types" as the least surprising option.

[stefanvodita]

I think having the two methods aligned, the way they are in your latest commit, makes sense.

[github-actions]

This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the [email protected] list. Thank you for your contribution!

[stefanvodita]

The clean-up looks good. Sorry it took so long to get a review.

[stefanvodita]

I see your point. Maybe it's worth adding an assertion?

[stefanvodita]

This would have to move up to version 9.11 because 9.10 is already in the release process.