Add missing spaces in concatenated strings

[sabi0]

Mostly changing code like this
"expected: " + currentFullFlushDelQueue + "but was: "
to
"expected: " + currentFullFlushDelQueue + " but was: "

But also fixing bugs like "" + i + numDocs => "" + (i + numDocs).

I took the liberty to also do some minor housekeeping in the affected files:

• corrected grammar and spelling mistakes
• removed unnecessary type parameters
• optimized API usage (e.g. "UTF-8" => UTF_8, assertThat() => assertEquals(), etc.)

[mikemccand]

Wow, thank you for the attention to detail @sabi0!

I'm curious: how did you uncover all of these corrections? Is there some static analysis tool that you started from?

[mikemccand]

Ahh because the class itself is already final, great!

[mikemccand]

There is another PR about removing the not-needed public in interfaces I think.

[mikemccand]

I'll backport for 9.10 soon.

[sabi0]

Thank you for checking this so quickly!

I started with a "Whitespace may be missing in string concatenation" inspection in IntelliJ IDEA.
After applying those fixes I went through the changed files again fixing file-level problems reported by the default inspections profile.

[mikemccand]

I started with a "Whitespace may be missing in string concatenation" inspection in IntelliJ IDEA. After applying those fixes I went through the changed files again fixing file-level problems reported by the default inspections profile.

Cool! Thanks for your attention to detail. I wish we could somehow fold these checks into Lucene's static code analysis tooling...

[sabi0]

https://www.jetbrains.com/qodana/

Open source projects can get a free license for any JetBrains products:
https://www.jetbrains.com/community/opensource/#support