Use growNoCopy in some places #12951
Conversation
| @@ -60,6 +60,13 @@ public void grow(int capacity) { | |||
| ref.bytes = ArrayUtil.grow(ref.bytes, capacity); | |||
| } | |||
|
|
|||
| /** | |||
| * Used to grow the builder without coping bytes. see {@link ArrayUtil#growNoCopy(byte[], int)}. | |||
There was a problem hiding this comment.
| * Used to grow the builder without coping bytes. see {@link ArrayUtil#growNoCopy(byte[], int)}. | |
| * Used to grow the builder without copying bytes. see {@link ArrayUtil#growNoCopy(byte[], int)}. |
There was a problem hiding this comment.
Thank you @dweiss , sorry for the typo!
|
This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the [email protected] list. Thank you for your contribution! |
There was a problem hiding this comment.
I think toUTF16 is another method in this class that can use growNoCopy. But it would require implementing it for IntsRefBuilder. Which can lead to using it in a few other places where we call IntsRefBuilder#grow now?
There was a problem hiding this comment.
Nice find! Thank you @epotyom !
# Conflicts: # lucene/codecs/src/java/org/apache/lucene/codecs/simpletext/SimpleTextDocValuesReader.java
|
Thank you for reviewing! |
|
This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the [email protected] list. Thank you for your contribution! |
|
I've backported to branch_9x as well. |
Found some
growmethod can be change togrowNoCopywhen reading code.