Output well-formed UTF-8 bytes in SimpleTextCodec's segmentinfos #12897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If needed, I'm happy to add versions of |
jpountz
reviewed
Dec 19, 2023
| } | ||
| byte[] bytes = new byte[(int) length]; | ||
| input.readBytes(bytes, 0, bytes.length); | ||
| StandardCharsets.UTF_8.newDecoder().decode(ByteBuffer.wrap(bytes)); |
There was a problem hiding this comment.
Maybe use Term#toString(BytesRef) which includes such checks already and configures a few more flags on the decoder that look useful?
The SimpleTextSegmentInfoFormat was writing the random byte array used as a segment's ID directly -- not converting to a simple text representation of the byte array. As a result, the segment infos were often malformed.
msfroh
force-pushed
the
fix_utf8_simpletextsegmentinfos
branch
from
f103563 to
59c3b8c
Compare
|
I implemented a similar change for binary doc values at #12987 |
slow-J
pushed a commit
to slow-J/lucene
that referenced
this pull request
Jan 16, 2024
…che#12897) The SimpleTextSegmentInfoFormat was writing the random byte array used as a segment's ID directly -- not converting to a simple text representation of the byte array. As a result, the segment infos were often malformed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The SimpleTextSegmentInfoFormat was writing the random byte array used as a segment's ID directly -- not converting to a simple text representation of the byte array. As a result, the segment infos were often malformed (as UTF-8 text).
The included test was failing before the change to write out the text representation of the byte array.