Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed the bug that cannot read the s3 directory tree #5055

Closed
wants to merge 1 commit into from
Closed

Fixed the bug that cannot read the s3 directory tree #5055

wants to merge 1 commit into from

Conversation

sjgllgh
Copy link
Contributor

@sjgllgh sjgllgh commented Dec 22, 2023

What is the purpose of the change

When using the S3 file system, it is impossible to correctly traverse directories. This PR fixes this bug and has been verified in our own environment.

Related issues/PRs

Related issues: #5052

  • I have read the Contributing Guidelines on pull requests.
  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the Linkis mailing list first)
  • If this is a code change: I have written unit tests to fully verify the new behavior.

peacewong
peacewong reviewed Dec 23, 2023
View reviewed changes
linkis-commons/linkis-storage/src/main/java/org/apache/linkis/storage/fs/impl/S3FileSystem.java
}
if (CollectionUtils.isNotEmpty(dirNames)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should use isBlank

@peacewong
Copy link
Contributor

ping ~ @sjgllgh

@sjgllgh sjgllgh closed this by deleting the head repository Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peacewong peacewong peacewong left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sjgllgh @peacewong