Support for storage resultSet in Parquet and Orc format #5024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChengJie1053
changed the title
peacewong
reviewed
Dec 6, 2023
| @@ -34,12 +40,17 @@ public class LinkisStorageConf { | |||
| public static final String ROW_BYTE_MAX_LEN_STR = | |||
| CommonVars.apply("wds.linkis.resultset.row.max.str", "2m").getValue(); | |||
|
|
|||
| public static final String ENGINE_RESULT_TYPE = | |||
| CommonVars.apply("wds.linkis.engine.resultSet.type", DOLPHIN, "Result type").getValue(); | |||
| @@ -134,15 +135,22 @@ public String[] getResultSetType() { | |||
|
|
|||
| @Override | |||
| public ResultSet<? extends MetaData, ? extends Record> getResultSetByPath(FsPath fsPath, Fs fs) { | |||
| ResultSet resultSet = null; | |||
| try (InputStream inputStream = fs.read(fsPath)) { | |||
There was a problem hiding this comment.
should support filename suffix judge
| import org.slf4j.LoggerFactory; | ||
|
|
||
| public class ParquetResultSetReader<K extends MetaData, V extends Record> | ||
| extends StorageResultSetReader { |
There was a problem hiding this comment.
should extends ResultSetReader
| "Can't get the value of the field, maybe the IO stream has been read or has been closed!(拿不到字段的值，也许IO流已读取完毕或已被关闭！)"); | ||
| } | ||
| try { | ||
| this.record = parquetReader.read(); |
There was a problem hiding this comment.
this.record = parquetReader.read(); should in hasNext method
| import org.slf4j.LoggerFactory; | ||
|
|
||
| public class ParquetResultSetWriter<K extends MetaData, V extends Record> | ||
| extends StorageResultSetWriter { |
There was a problem hiding this comment.
should extends ResultSetWriter
| try { | ||
| TableRecord tableRecord = (TableRecord) record; | ||
| Object[] row = tableRecord.row; | ||
| try (ParquetWriter<GenericRecord> writer = |
There was a problem hiding this comment.
writer should be class var, only init once
There was a problem hiding this comment.
Ok, thanks for reviewing the code
ChengJie1053
changed the title
ChengJie1053
changed the title
peacewong
reviewed
Jan 16, 2024
|
|
||
| @Override | ||
| public int skip(int recordNum) throws IOException { | ||
| return 0; |
|
|
||
| @Override | ||
| public long getPosition() throws IOException { | ||
| return 0; |
|
|
||
| @Override | ||
| public long available() throws IOException { | ||
| return 0; |
|
|
||
| @Override | ||
| public int skip(int recordNum) throws IOException { | ||
| return 0; |
| } | ||
|
|
||
| @Override | ||
| public long available() throws IOException { |
|
|
||
| @Override | ||
| public long getPosition() throws IOException { | ||
| return 0; |
| try { | ||
| resultSetReader = new ParquetResultSetReader<>(resultSet, inputStream, fsPath); | ||
| } catch (IOException e) { | ||
| throw new RuntimeException("Failed to read parquet", e); |
| @@ -73,7 +73,9 @@ public interface FileSource extends Closeable { | |||
| (path, suffix) -> path.endsWith("." + suffix); | |||
|
|
|||
| static boolean isResultSet(String path) { | |||
| return suffixPredicate.apply(path, fileType[0]); | |||
| return suffixPredicate.apply(path, fileType[0]) | |||
| @@ -404,6 +404,10 @@ public Message getDirFileTrees( | |||
| FsPathListWithError fsPathListWithError = fileSystem.listPathWithError(fsPath); | |||
| if (fsPathListWithError != null) { | |||
| for (FsPath children : fsPathListWithError.getFsPaths()) { | |||
| // 兼容parquet和orc,跳过.crc文件 | |||
There was a problem hiding this comment.
Ok, thanks for reviewing the code
# Conflicts: # tool/dependencies/known-dependencies.txt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for storing result sets in Parquet format
linkis.engine.resultSet.typedefault value isdolphin, Can be modified toparquetandorcThe maven compilation command is
mvn clean install -Pstorage-parquet -Pstorage-orc -Dmaven.test.skip=true