Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize HBase engine dependencies #4976

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Optimize HBase engine dependencies #4976

merged 1 commit into from
Nov 22, 2023

Conversation

CCweixiao
Copy link
Contributor

@CCweixiao CCweixiao commented Nov 22, 2023 •
edited by peacewong
Loading

What is the purpose of the change

Optimize HBase engine dependencies and move java exception class from scala package to java package..

Related issues/PRs

Related issues: #2533
Related pr: #4891

Brief change log

  • Move java exception class ExecutorInitException from scala package to java package;
  • Optimize HBase engine dependencies.

Checklist

  • I have read the Contributing Guidelines on pull requests.
  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the Linkis mailing list first)
  • If this is a code change: I have written unit tests to fully verify the new behavior.

@CCweixiao CCweixiao requested a review from peacewong November 22, 2023 02:25
@CCweixiao CCweixiao force-pushed the dev-hbase-fix2 branch 2 times, most recently from b3301e3 to 8458c70 Compare November 22, 2023 03:16
peacewong
peacewong previously approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@peacewong peacewong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

peacewong
peacewong approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@peacewong peacewong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@peacewong peacewong changed the title Optimize HBase engine dependencies and move java exception class from… Optimize HBase engine dependencies Nov 22, 2023
@peacewong peacewong merged commit 1afc612 into apache:master Nov 22, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peacewong peacewong peacewong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CCweixiao @peacewong