Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4907 Incorrect adjustment of log printing resource parameters #4908

Merged
merged 1 commit into from
Sep 20, 2023
Merged

#4907 Incorrect adjustment of log printing resource parameters #4908

merged 1 commit into from
Sep 20, 2023

Conversation

sjgllgh
Copy link
Contributor

@sjgllgh sjgllgh commented Sep 18, 2023

What is the purpose of the change

Incorrect adjustment of log printing resource parameters

Related issues/PRs

Related issues: #4907

Brief change log

  • update Function LoadInstanceResource
    Change Before :
    public String toString() {
    return String.format(
    "Number of instances(实例数):%d,(RAM)内存:%s ,cpu: %s",
    this.getInstances(), this.getCores(), this.getMemory());
    }

Change After:
public String toString() {
return String.format(
"Number of instances(实例数):%d,(RAM)内存:%s ,cpu: %s",
this.getInstances(), this.getMemory(), this.getCores());
}

Checklist

  • I have read the Contributing Guidelines on pull requests.
  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the Linkis mailing list first)
  • If this is a code change: I have written unit tests to fully verify the new behavior.

Copy link
Contributor

@jackxu2011 jackxu2011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jackxu2011 jackxu2011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@peacewong peacewong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@peacewong peacewong merged commit 4868920 into apache:master Sep 20, 2023
12 checks passed
@sjgllgh sjgllgh deleted the fix-bug_4907_linkismanager branch September 22, 2023 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants