-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support submit pyspark once job on k8s and add clusterlabel to combinedlabel #4906
Merged
Merged
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
3bcfbb2
feat: support submit pyspark once job on k8s
lenoxzhao 6b83b37
feat: modify variable name
lenoxzhao d69f01c
feat: add method to build k8s client from kubeConfig
lenoxzhao 186acc0
feat: add Spark UI port configuration for spark on k8s once job
lenoxzhao 70112a8
feat: rename userCreatorEngineTypeLabel
lenoxzhao 44af15b
feat: merge podIP and port into url
lenoxzhao 67b05ea
fix: replace 'empty' with 'blank'
lenoxzhao File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -247,8 +247,7 @@ public ResultResource requestResource(List<Label<?>> labels, NodeResource resour | |
|
||
List<PersistenceLock> persistenceLocks = new ArrayList<>(); | ||
EMInstanceLabel emInstanceLabel = labelContainer.getEMInstanceLabel(); | ||
CombinedLabel userCreatorEngineTypeLabel = | ||
labelContainer.getCombinedUserCreatorEngineTypeLabel(); | ||
CombinedLabel userCreatorEngineTypeLabel = labelContainer.getCombinedResourceLabel(); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. rename userCreatorEngineTypeLabel is better There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Already rename it. |
||
|
||
try { | ||
// check ecm resource if not enough return | ||
|
@@ -294,9 +293,7 @@ public ResultResource requestResource(List<Label<?>> labels, NodeResource resour | |
labelResource.setLockedResource( | ||
labelResource.getLockedResource().add(resource.getLockedResource())); | ||
labelResourceService.setLabelResource( | ||
label, | ||
labelResource, | ||
labelContainer.getCombinedUserCreatorEngineTypeLabel().getStringValue()); | ||
label, labelResource, labelContainer.getCombinedResourceLabel().getStringValue()); | ||
logger.info( | ||
String.format( | ||
"ResourceChanged:%s --> %s", label.getStringValue(), labelResource.toString())); | ||
|
@@ -330,9 +327,7 @@ public ResultResource requestResource(List<Label<?>> labels, NodeResource resour | |
|
||
// add ec resource | ||
labelResourceService.setEngineConnLabelResource( | ||
engineInstanceLabel, | ||
resource, | ||
labelContainer.getCombinedUserCreatorEngineTypeLabel().getStringValue()); | ||
engineInstanceLabel, resource, labelContainer.getCombinedResourceLabel().getStringValue()); | ||
// record engine locked resource | ||
labelContainer.getLabels().add(engineInstanceLabel); | ||
resourceLogService.recordUserResourceAction( | ||
|
@@ -441,7 +436,7 @@ public void resourceUsed(List<Label<?>> labels, NodeResource usedResource) { | |
labelResourceService.setLabelResource( | ||
engineInstanceLabel, | ||
lockedResource, | ||
labelContainer.getCombinedUserCreatorEngineTypeLabel().getStringValue()); | ||
labelContainer.getCombinedResourceLabel().getStringValue()); | ||
resourceLogService.success( | ||
ChangeType.ENGINE_INIT, lockedResource.getLockedResource(), engineInstanceLabel, null); | ||
} catch (Exception exception) { | ||
|
@@ -481,7 +476,7 @@ public void resourceUsed(List<Label<?>> labels, NodeResource usedResource) { | |
labelResourceService.setLabelResource( | ||
label, | ||
labelResource, | ||
labelContainer.getCombinedUserCreatorEngineTypeLabel().getStringValue()); | ||
labelContainer.getCombinedResourceLabel().getStringValue()); | ||
labelResourceSet.add( | ||
new LabelResourceMapping(label, addedResource, ResourceOperationType.USED)); | ||
resourceCheck(label, labelResource); | ||
|
@@ -493,7 +488,7 @@ public void resourceUsed(List<Label<?>> labels, NodeResource usedResource) { | |
|
||
if (label | ||
.getClass() | ||
.isAssignableFrom(labelContainer.getCombinedUserCreatorEngineTypeLabel().getClass())) { | ||
.isAssignableFrom(labelContainer.getCombinedResourceLabel().getClass())) { | ||
resourceLogService.recordUserResourceAction( | ||
labelContainer, | ||
persistenceResource.getTicketId(), | ||
|
@@ -704,9 +699,7 @@ public void resourceReleased(EngineNode ecNode) { | |
labelResourceService.setLabelResource( | ||
label, | ||
labelResource, | ||
labelContainer | ||
.getCombinedUserCreatorEngineTypeLabel() | ||
.getStringValue()); | ||
labelContainer.getCombinedResourceLabel().getStringValue()); | ||
resourceCheck(label, labelResource); | ||
} | ||
}, | ||
|
@@ -725,8 +718,7 @@ public void resourceReleased(EngineNode ecNode) { | |
|
||
if (label | ||
.getClass() | ||
.isAssignableFrom( | ||
labelContainer.getCombinedUserCreatorEngineTypeLabel().getClass())) { | ||
.isAssignableFrom(labelContainer.getCombinedResourceLabel().getClass())) { | ||
resourceLogService.recordUserResourceAction( | ||
labelContainer, | ||
persistenceResource.getTicketId(), | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove prefix of
wds