Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: add a note to the upgrade notes #17910

Merged
merged 4 commits into from
Nov 23, 2024
Merged

Conversation

Rancho-7
Copy link
Contributor

@Rancho-7 Rancho-7 commented Nov 22, 2024

add a note to the upgrade notes

JIRA:issues.apache.org/jira/browse/KAFKA-12690

Snipaste_2024-11-23_17-43-14

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@@ -137,6 +137,8 @@ <h5><a id="upgrade_400_notable" href="#upgrade_400_notable">Notable changes in 4
<ul>
<li>The <code>enable.idempotence</code> configuration will no longer automatically fall back when the <code>max.in.flight.requests.per.connection</code> value exceeds 5.
</li>
<li>The deprecated <code>sendOffsetsToTransaction</code> method has been removed from the Producer API.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please use sendOffsetsToTransaction(Map<TopicPartition, OffsetAndMetadata>, String) instead?

Copy link
Contributor Author

@Rancho-7 Rancho-7 Nov 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please use sendOffsetsToTransaction(Map<TopicPartition, OffsetAndMetadata>, String) instead?

Sure.

Snipaste_2024-11-23_17-43-14

Copy link
Contributor

@chia7712 chia7712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rancho-7 thanks for this patch LGTM

@chia7712 chia7712 merged commit 637b22f into apache:trunk Nov 23, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants