-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor: add a note to the upgrade notes #17910
Conversation
docs/upgrade.html
Outdated
@@ -137,6 +137,8 @@ <h5><a id="upgrade_400_notable" href="#upgrade_400_notable">Notable changes in 4 | |||
<ul> | |||
<li>The <code>enable.idempotence</code> configuration will no longer automatically fall back when the <code>max.in.flight.requests.per.connection</code> value exceeds 5. | |||
</li> | |||
<li>The deprecated <code>sendOffsetsToTransaction</code> method has been removed from the Producer API. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please use sendOffsetsToTransaction(Map<TopicPartition, OffsetAndMetadata>, String)
instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Rancho-7 thanks for this patch LGTM
add a note to the upgrade notes
JIRA:issues.apache.org/jira/browse/KAFKA-12690
Committer Checklist (excluded from commit message)