Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA-17972: Default all JUnit tests to KRaft #17727

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from

Conversation

cmccabe
Copy link
Contributor

@cmccabe cmccabe commented Nov 9, 2024

No description provided.

@github-actions github-actions bot added core Kafka Broker tests Test fixes (including flaky tests) small Small PRs labels Nov 9, 2024
@chia7712
Copy link
Contributor

chia7712 commented Nov 9, 2024

Out of curiosity, what is the next if we have a zk-only list?

  1. migrate the tests to Kraft if the tests are required by Kraft too
  2. Remove the tests if the bugs happen in Kraft only (similar to KAFKA-17925: Convert Kafka Client integration tests to use KRaft #17670 (comment))

Thanks

@cmccabe
Copy link
Contributor Author

cmccabe commented Nov 9, 2024

Out of curiosity, what is the next if we have a zk-only list?

There are some things that don't need to be tested any more, because they're gone. For example, there are a bunch of tests of "topics in deleting state" which can go, because deleting state is gone.

There are probably some tests that need to be migrated to KRaft, but haven't been yet. Depending on how many of them there are, we may need to put a @Disable on some of these and create a follow-up JIRA so that we can unblock the broader zk removal effort.

@cmccabe
Copy link
Contributor Author

cmccabe commented Nov 10, 2024

I split the fix of MetricsTest out to #17744

@cmccabe
Copy link
Contributor Author

cmccabe commented Nov 10, 2024

Remove MetadataRequestBetweenDifferentIbpTest.scala in #17745

@cmccabe
Copy link
Contributor Author

cmccabe commented Nov 10, 2024

Convert DescribeLogDirsRequestTest : #17746

@cmccabe
Copy link
Contributor Author

cmccabe commented Nov 11, 2024

another fix here #17757

@cmccabe
Copy link
Contributor Author

cmccabe commented Nov 11, 2024

Fixing FetchRequestDownConversionConfigTest here : #17759

@cmccabe
Copy link
Contributor Author

cmccabe commented Nov 11, 2024

Convert ConsumerTopicCreationTest : https://github.com/apache/kafka/pull/17760/files

@cmccabe
Copy link
Contributor Author

cmccabe commented Nov 11, 2024

Convert AddPartitionsToTxnRequestServerTest #17762

@cmccabe
Copy link
Contributor Author

cmccabe commented Nov 12, 2024

Created #17765 for fixing the tests inheriting from RebootstrapTest

@cmccabe
Copy link
Contributor Author

cmccabe commented Nov 12, 2024

Convert RackAwareAutoTopicCreationTest to KRaft: #17766

@cmccabe
Copy link
Contributor Author

cmccabe commented Nov 12, 2024

Convert ProduceRequestTest : #17780

@cmccabe
Copy link
Contributor Author

cmccabe commented Nov 13, 2024

Convert GssapiAuthenticationTest : https://github.com/apache/kafka/pull/17786/files

@cmccabe
Copy link
Contributor Author

cmccabe commented Nov 13, 2024

Convert SaslClientsWithInvalidCredentialsTest.scala to KRaft #17803

@cmccabe
Copy link
Contributor Author

cmccabe commented Nov 21, 2024

remove SaslPlainPlaintextConsumerTest.testZkAclsDisabled: #17902

@cmccabe
Copy link
Contributor Author

cmccabe commented Nov 22, 2024

For fixing DynamicBrokerReconfigurationTest : #17905

@cmccabe
Copy link
Contributor Author

cmccabe commented Nov 22, 2024

Remove some ZK tests here https://github.com/apache/kafka/pull/17913/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Kafka Broker small Small PRs tests Test fixes (including flaky tests)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants