Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce WorkerProcessor in QueryEngine #14063

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Introduce WorkerProcessor in QueryEngine #14063

wants to merge 11 commits into from

Conversation

Sh-Zh-7
Copy link
Contributor

@Sh-Zh-7 Sh-Zh-7 commented Nov 12, 2024

Description

This PR introduce basic WorkerProcessor framework in Trino to help develop future Window Functions and UDF in Table Model.

Cpaulyz
Cpaulyz requested changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@Cpaulyz Cpaulyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing apache header.

And please add some javadocs to describe the functions, parameters, and return values, especially for interfaces, tool and state.

@Cpaulyz
Copy link
Contributor

Cpaulyz commented Nov 14, 2024

Add these files in LICENSE https://github.com/apache/iotdb/blob/master/LICENSE

@Sh-Zh-7 Sh-Zh-7 requested a review from Cpaulyz November 14, 2024 17:19
@Sh-Zh-7
Copy link
Contributor Author

Sh-Zh-7 commented Nov 14, 2024

PTAL~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cpaulyz Cpaulyz Awaiting requested review from Cpaulyz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sh-Zh-7 @Cpaulyz