Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-11531][Manager] Fix bug in DolphinScheduler engine #11532

Merged
merged 5 commits into from
Nov 25, 2024

Conversation

emptyOVO
Copy link
Contributor

@emptyOVO emptyOVO commented Nov 21, 2024

Fixes #11531

Motivation

  • A project in DS engine doesn't need to be created at bean initialize time, so it only needs to be called when a register-related-handle method is called, and this also allows data synchronization at each processing time
  • delete operation need to add retry mechanism

Modifications

  • add start() method in handleRegister(), handleUnregister() and handleUpdate(), before related operation be called
  • because of situation below, deleting operation should add retry mechanism
    image

Verifying this change

(Please pick either of the following options)

  • This change is a trivial rework/code cleanup without any test coverage.

  • This change is already covered by existing tests, such as:
    (please describe tests)

  • This change added tests and can be verified as follows:

    (example:)

    • Added integration tests for end-to-end deployment with large payloads (10MB)
    • Extended integration test for recovery after broker failure

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation

aloyszhang
aloyszhang previously approved these changes Nov 25, 2024
@dockerzhang dockerzhang merged commit ace3362 into apache:master Nov 25, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature][Manager] Fix bug in DolphinScheduler engine
4 participants