-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[INLONG-11531][Manager] Fix bug in DolphinScheduler engine #11532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emptyOVO
force-pushed
the
INLONG-11531
branch
from
November 22, 2024 09:57
921aa1c
to
f817b22
Compare
aloyszhang
reviewed
Nov 24, 2024
.../src/main/java/org/apache/inlong/manager/schedule/dolphinscheduler/DolphinScheduleUtils.java
Show resolved
Hide resolved
aloyszhang
previously approved these changes
Nov 25, 2024
fuweng11
reviewed
Nov 25, 2024
.../src/main/java/org/apache/inlong/manager/schedule/dolphinscheduler/DolphinScheduleUtils.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/apache/inlong/manager/schedule/dolphinscheduler/DolphinScheduleUtils.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/apache/inlong/manager/schedule/dolphinscheduler/DolphinScheduleUtils.java
Outdated
Show resolved
Hide resolved
fuweng11
reviewed
Nov 25, 2024
.../src/main/java/org/apache/inlong/manager/schedule/dolphinscheduler/DolphinScheduleUtils.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/apache/inlong/manager/schedule/dolphinscheduler/DolphinScheduleUtils.java
Outdated
Show resolved
Hide resolved
fuweng11
reviewed
Nov 25, 2024
.../src/main/java/org/apache/inlong/manager/schedule/dolphinscheduler/DolphinScheduleUtils.java
Outdated
Show resolved
Hide resolved
fuweng11
reviewed
Nov 25, 2024
.../src/main/java/org/apache/inlong/manager/schedule/dolphinscheduler/DolphinScheduleUtils.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/apache/inlong/manager/schedule/dolphinscheduler/DolphinScheduleUtils.java
Outdated
Show resolved
Hide resolved
fuweng11
approved these changes
Nov 25, 2024
dockerzhang
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11531
Motivation
Modifications
start()
method inhandleRegister()
,handleUnregister()
andhandleUpdate()
, before related operation be calledVerifying this change
(Please pick either of the following options)
This change is a trivial rework/code cleanup without any test coverage.
This change is already covered by existing tests, such as:
(please describe tests)
This change added tests and can be verified as follows:
(example:)
Documentation