[TOREE-526] Enable jupyter_kernel_test #202
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jupyter_kernel_test seems revived, try first.
Some conclusions:
Currently, Toree implementation is based on Jupyter 5.0 protocol, and the latest version is 5.4.
The
jupyter_kernel_test
seems to become stricter now. e.g.the docs say
But Toree's implementation does not satisfy such restriction. e.g. the
KernelInfoReply
does not contain "status", so that it will be failed withSo we need to revise the protocol definition and our implementation before enabling the
system-test
.