Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TOREE-526] Enable jupyter_kernel_test #202

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pan3793
Copy link
Member

@pan3793 pan3793 commented Aug 5, 2023

jupyter_kernel_test seems revived, try first.

Some conclusions:

Currently, Toree implementation is based on Jupyter 5.0 protocol, and the latest version is 5.4.

The jupyter_kernel_test seems to become stricter now. e.g.

the docs say

All reply messages have a 'status' field ...

But Toree's implementation does not satisfy such restriction. e.g. the KernelInfoReply does not contain "status", so that it will be failed with

======================================================================
ERROR: test_kernel_info (__main__.ToreeScalaKernelTests.test_kernel_info)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/opt/conda/lib/python3.11/site-packages/jupyter_kernel_test/__init__.py", line 61, in test_kernel_info
    validate_message(reply, "kernel_info_reply", msg_id)
  File "/opt/conda/lib/python3.11/site-packages/jupyter_kernel_test/msgspec_v5.py", line 149, in validate_message
    raise ValidationError(str(e)) from None
jsonschema.exceptions.ValidationError: 'status'

So we need to revise the protocol definition and our implementation before enabling the system-test.

@pan3793
Copy link
Member Author

pan3793 commented Aug 8, 2023

#207 is opened to address "status" issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant