Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TOREE-492] Add DataFrame displayer #167

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

manuzhang
Copy link

No description provided.

@manuzhang
Copy link
Author

@lresende could you please take a look ?

@lresende
Copy link
Member

  • What's the main difference between this and %dataframe
  • Do we have to do any special handle for dataset ?
  • Could you please add a little user documentation on how to use it (other displayers might be helpful as well).
  • Could you please add a simple test case

@manuzhang
Copy link
Author

@lresende

  1. I was not aware of the %dataframe magic. This PR adds a syntactic sugar over df.head(20) where both df and df.head need %truncation off to be displayed in html format. In practice, I do a lot of df.show()s to get sample results which are not pretty printed. Now I know it can be achieved through %dataframe but I wonder it would better to display sampled df in html format by default (without any magic).

  2. Do you know where to add the corresponding test case and doc for ScalaDisplayer ? All I've found are some notebook tutorials.

@mohammedi-haroune
Copy link

@manuzhang It would be great if the displayer works by default (the same way as a pandas data frame). Is that working for you ?

@manuzhang
Copy link
Author

@mohammedi-haroune yes, that works for me

@mohammedi-haroune
Copy link

@manuzhang Thanks for you reactivity. I will check it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants