Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easier for engineers unfamiliar with the project to see where all the crates live and prevents lots of nested
target/
andCargo.lock
files from cluttering up the tree.It's perhaps not as useful as for other projects, since optee-utee still needs to be built via Xargo, which means
cargo build
from the root can't build everything. But the other benefits still apply.I had to rename the "systest" crates inside optee-teec and optee-utee so their names don't conflict. I also didn't include examples in the workspace yet, since every example currently has the same three crate names, meaning multiple can't coexist in one workspace. Also, the example
Makefile
s andtests/
scripts hardcode per-exampletarget/
dirs.If we did add the examples to the workspace, we could build all of them much faster since they'd share a dependency graph. Doing that is just out of scope of this PR.
There are also a couple of cleanup commits tossed in here for
.gitignore
and someCargo.lock
s, so if you merge please don't squash. Thanks!