Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kie-issues#1610] Remove WorkItemDefinition mechanism #3766

Merged
merged 5 commits into from
Nov 19, 2024

Conversation

josedee
Copy link
Contributor

@josedee josedee commented Nov 11, 2024

Closes apache/incubator-kie-issues#1610

Remove WorkItemDefinition mechanism from the Workflow engine (.wid) files support on the BPMN Editor / engine.

@josedee josedee changed the title Removed WorkItemDefinition mechanism Remove WorkItemDefinition mechanism Nov 11, 2024
@josedee josedee changed the title Remove WorkItemDefinition mechanism [kie-issues#1610] Remove WorkItemDefinition mechanism Nov 11, 2024
@josedee josedee marked this pull request as ready for review November 11, 2024 18:34
Copy link
Contributor

@yesamer yesamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HI @josedee, thank you for your PR.
I found some references of *.wid files in

  • .gitignore files
  • pom.xml related to springboot integration tests

To find them, you need to search *.wid key in the repo.
I guess we should remove them too, is that right @elguardian ?

@yesamer
Copy link
Contributor

yesamer commented Nov 14, 2024

@josedee Thank you for applying the changes!

@josedee @elguardian @pefernan @martinweiler I noticed we have a lot of wid files in the repo (eg apache/incubator-kie-kogito-runtimes/jbpm/jbpm-flow-builder/src/test/resources/org/jbpm/process/workitem/repositorysingledir/repowid.wid), should we remove them all?

Screenshot 2024-11-14 at 18 21 56

Copy link
Contributor

@yesamer yesamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@josedee Thank you!

@elguardian elguardian merged commit 13644c5 into apache:main Nov 19, 2024
5 of 6 checks passed
@kie-ci3
Copy link
Contributor

kie-ci3 commented Nov 19, 2024

PR job #5 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3766 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3766/5/display/redirect

Test results:

  • PASSED: 3480
  • FAILED: 1

Those are the test failures:

org.jbpm.bpmn2.IntermediateEventTest.testIntermediateCatchEventTimerCycle3
expected: 3
but was: 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove support for Work Item Definition (.wid) files
5 participants