-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[kie-issues#1610] Remove WorkItemDefinition mechanism #3766
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HI @josedee, thank you for your PR.
I found some references of *.wid files in
.gitignore
files- pom.xml related to springboot integration tests
To find them, you need to search *.wid
key in the repo.
I guess we should remove them too, is that right @elguardian ?
@josedee Thank you for applying the changes! @josedee @elguardian @pefernan @martinweiler I noticed we have a lot of wid files in the repo (eg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@josedee Thank you!
PR job Reproducerbuild-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3766 --skipParallelCheckout NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3766/5/display/redirect Test results:
Those are the test failures: |
Closes apache/incubator-kie-issues#1610
Remove WorkItemDefinition mechanism from the Workflow engine (.wid) files support on the BPMN Editor / engine.