Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NO_ISSUE] Cleanup incubator-kie-issues#1504 - Conditionally build all or only reproducible modules based on only.reproducible flag #3693

Merged
merged 2 commits into from
Oct 7, 2024

Conversation

gitgabrio
Copy link
Contributor

Refactoring of #3687

Keep the same behavior, but better written

How to replicate CI configuration locally?

Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.

build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.

…l or only reproducible modules based on only.reproducible flag
Copy link
Contributor

@jstastny-cz jstastny-cz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kie-ci3
Copy link
Contributor

kie-ci3 commented Oct 7, 2024

PR job #2 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3693 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3693/2/display/redirect

Test results:

  • PASSED: 3346
  • FAILED: 1

Those are the test failures:

org.jbpm.bpmn2.IntermediateEventTest.testIntermediateCatchEventTimerCycle3
expected: 3
but was: 2

@gitgabrio gitgabrio merged commit 2e422e0 into apache:main Oct 7, 2024
5 of 6 checks passed
@gitgabrio gitgabrio deleted the fix_1504 branch October 7, 2024 11:49
rgdoliveira pushed a commit to rgdoliveira/kogito-runtimes that referenced this pull request Oct 10, 2024
…l or only reproducible modules based on only.reproducible flag (apache#3693)

Co-authored-by: Gabriele-Cardosi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants