Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1719 - Add Maven 3.9.3, Quarkus 3.2.9.Final and update Java images #1720

Merged
merged 20 commits into from
Dec 28, 2023

Conversation

ricardozanini
Copy link
Member

Many thanks for submitting your Pull Request ❤️!

Fixes #1719 - this PR adds the Maven version required for Quarkus 3. It won't work right off the bat until the SNAPSHOTS get pushed to Nexus and our extensions get published to the registry.

Additionally, the swf images are in an error state since our extensions are not published in the Quarkus 3 repository. We need to go through the renaming first before releasing 10.x. cc @porcelli @krisv

@mariofusco I'm adding you just for validation.

Please make sure your PR meets the following requirements:

  • You have read the contributors guide
  • Pull Request title is properly formatted: [KOGITO|RHPAM-XYZ] Subject
  • Pull Request contains link to the JIRA issue
  • Pull Request contains description of the issue
  • Pull Request does not include fixes for issues other than the main ticket
  • Your feature/bug fix has a testcase that verifies it
  • You've tested the new feature/bug fix in an actual OpenShift cluster
  • You've added a RELEASE_NOTES.md entry regarding this change
How to retest this PR or trigger a specific build:
  • (Re)run Jenkins tests
    Please add comment: Jenkins [test|retest] this

  • Prod tests
    Please add comment: Jenkins (re)run [prod|Prod|PROD]

How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

@kie-ci3
Copy link
Contributor

kie-ci3 commented Dec 15, 2023

PR job #8 was: FAILURE
Possible explanation: Pipeline failure or project build failure

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest/job/kogito-images.build-and-test/8/display/redirect
See console log:

Console Logs [Pipeline] }
[Pipeline] // stage
[Pipeline] }
Failed in branch kogito-trusty-postgresql
[Pipeline] error
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
Failed in branch kogito-jobs-service-allinone
[Pipeline] error
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
Failed in branch kogito-trusty-ui
[Pipeline] error
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
Failed in branch kogito-management-console
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
[Pipeline] error
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
Failed in branch kogito-task-console
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
[Pipeline] unstable
WARNING: Tests on kogito-s2i-builder seems to have failed
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
[Pipeline] // parallel
[Pipeline] }
[Pipeline] // dir
[Pipeline] }
[Pipeline] // script
[Pipeline] }
[Pipeline] // stage
[Pipeline] stage
[Pipeline] { (Declarative: Post Actions)
[Pipeline] script
[Pipeline] {
[Pipeline] sh
+ wget --no-check-certificate -qO - 'https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest/job/kogito-images.build-and-test/8/api/json?depth=0'
[Pipeline] readJSON
[Pipeline] sh

@ricardozanini
Copy link
Member Author

ricardozanini commented Dec 18, 2023

@mariofusco @krisv @porcelli

We can hold this PR until we get a 10.x snapshot. But now, our images are broken and we can't build from the main anymore since Quarkus 3 doesn't have our 10.x extensions published in their registry.

We must:

1. Initiate a SNAPSHOT 10.x release with Quarkus 3
2. Release in their registry (can we do SNAPSHOTs there?)
3. Merge this PR and verify the CI

EDIT: Actually, there was a bug in the create-app.sh where we used to use the versions deployed on Quarkus registry and not the versions on Nexus. The 2.0.0-Snapshot was buggy because pmml 9.x was not found in the repo. 999-SNAPSHOT hasn't uploaded yet, so after that, we can test to see if everything is alright.

@baldimir
Copy link
Contributor

We have the 999-SNAPSHOTS, so I restarted the PR check on Jenkins.

@ricardozanini
Copy link
Member Author

We have the 999-SNAPSHOTS, so I restarted the PR check on Jenkins.

I need to upgrade to java 17 too

@apache apache deleted a comment from kie-ci3 Dec 22, 2023
@apache apache deleted a comment from kie-ci3 Dec 22, 2023
@apache apache deleted a comment from kie-ci3 Dec 22, 2023
@apache apache deleted a comment from kie-ci3 Dec 22, 2023
@apache apache deleted a comment from kie-ci3 Dec 22, 2023
@ricardozanini
Copy link
Member Author

I think I was able to fix every problems and upgrade Java, Maven, and Quarkus.

The only problem left is the s2i builder tests that depends on quay.io/kiegroup/kogito-runtime-jvm:latest. Since now every build runs on its on context, we won't have access to this image from the s2i pipeline. The alternatives we have:

  1. Build the kogito-runtime-jvm together with the s2i pipeline.
  2. Share the context between kogito-runtime-jvm and s2i, or make them run in a single pipeline.

The nightly won't have problems since we should push the tags and the runtime runs before s2i.

We can merge this one if only s2i is failing in the tests in the behave depending on the runtime image. Then, we can fix this problem in a follow-up PR.

The quay.io/kiegroup/kogito-runtime-jvm:latest image is in Java 11, that's the reason you see the failures.

@apache apache deleted a comment from kie-ci3 Dec 27, 2023
@ricardozanini
Copy link
Member Author

These PRs broke the current data-index build run:

I'll re-run again tomorrow to catch the last nightlies.

[INFO] -------------------------------------------------------------
[ERROR] COMPILATION ERROR : 
[INFO] -------------------------------------------------------------
[ERROR] /tmp/data-index-service-postgresql/kogito-apps/data-index/data-index-common/src/main/java/org/kie/kogito/index/event/mapper/ProcessInstanceNodeDataEventMerger.java:[72,46] cannot find symbol
  symbol:   variable EVENT_TYPE_ERROR
  location: class org.kie.kogito.event.process.ProcessInstanceNodeEventBody
[INFO] 1 error
[INFO] -------------------------------------------------------------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for Kogito Apps 999-SNAPSHOT:
[INFO] 
[INFO] Kogito Apps ........................................ SUCCESS [01:48 min]
[INFO] Kogito Apps :: Build Parent BOM .................... SUCCESS [  0.051 s]
[INFO] Kogito Apps :: Persistence Commons ................. SUCCESS [  0.045 s]
[INFO] Kogito Apps :: Persistence Commons API ............. SUCCESS [ 39.514 s]
[INFO] Kogito Apps :: Persistence Commons Protobuf ........ SUCCESS [  5.567 s]
[INFO] Kogito Apps :: Persistence Commons PostgreSQL ...... SUCCESS [ 48.761 s]
[INFO] Kogito Apps :: Data Index .......................... SUCCESS [  0.044 s]
[INFO] Kogito Apps :: Data Index Storage .................. SUCCESS [  0.040 s]
[INFO] Kogito Apps :: Data Index Storage API .............. SUCCESS [  1.373 s]
[INFO] Kogito Apps :: Data Index Storage Protobuf ......... SUCCESS [  3.409 s]
[INFO] Kogito Apps :: Data Index Storage PostgreSQL ....... SUCCESS [  4.182 s]
[INFO] Kogito Apps :: Data Index Common ................... FAILURE [ 19.151 s]
[INFO] Kogito Apps :: Data Index Test Utils ............... SKIPPED
[INFO] Kogito Apps :: Data Index GraphQL .................. SKIPPED
[INFO] Kogito Apps :: Data Index Service .................. SKIPPED
[INFO] Kogito Apps :: Data Index Service Common ........... SKIPPED
[INFO] Kogito Apps :: Data Index Service with PostgreSQL .. SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  07:11 min
[INFO] Finished at: 2023-12-27T15:52:19Z
[INFO] ------------------------------------------------------------------------
Failed in branch kogito-data-index-postgresql
[Pipeline] error
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
Failed in branch kogito-data-index-ephemeral
[Pipeline] error
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
Failed in branch kogito-data-index-oracle
[Pipeline] error
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
Failed in branch kogito-data-index-infinispan
[Pipeline] error
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
Failed in branch kogito-data-index-mongodb

Regarding trusty-postgres, it runs now successfully. The sleep added to the command might hang the container. I couldn't find more info, but I'll keep an eye on it.

@ricardozanini
Copy link
Member Author

Everything is green, but the data-index images. The reason I just explained before.

@apache apache deleted a comment from kie-ci3 Dec 27, 2023
@ricardozanini
Copy link
Member Author

Small adjustments in s2i behave tests.

@apache apache deleted a comment from kie-ci3 Dec 27, 2023
@apache apache deleted a comment from kie-ci3 Dec 27, 2023
@mariofusco
Copy link
Contributor

These PRs broke the current data-index build run:

* [[incubator-kie-issues-576] Data Audit apps for kogito incubator-kie-kogito-apps#1905](https://github.com/apache/incubator-kie-kogito-apps/pull/1905)

* [[incubator-kie-issues-576] Data Audit apps for kogito incubator-kie-kogito-runtimes#3267](https://github.com/apache/incubator-kie-kogito-runtimes/pull/3267)

/cc @pefernan @elguardian

@pefernan
Copy link
Contributor

@mariofusco let me take a look

@apache apache deleted a comment from kie-ci3 Dec 28, 2023
@apache apache deleted a comment from kie-ci3 Dec 28, 2023
@pefernan
Copy link
Contributor

@ricardozanini @mariofusco the data-index issue should disappear with the latest snapshots. The latest error appear to be related to an image test failure (job-service-infinispan)

@ricardozanini
Copy link
Member Author

ricardozanini commented Dec 28, 2023

I've added an ignore tag to the Verify if a custom certificate is correctly handled:

https://github.com/apache/incubator-kie-kogito-images/blob/main/tests/features/common-custom-truststore.feature#L21

Since it's making cekit hanging trying to ps a dead container. The container starts and dies since the truststore is invalid, cekit tries to ps to get the log and hangs.

EDIT: Issue created #1722

@ricardozanini
Copy link
Member Author

ricardozanini commented Dec 28, 2023

@ricardozanini @mariofusco the data-index issue should disappear with the latest snapshots. The latest error appear to be related to an image test failure (job-service-infinispan)

I've restarted the CI with my last commit. Let's observe. The test failure I just explained why in my last comment and shouldn't occur anymore.

@pefernan
Copy link
Contributor

@ricardozanini great, I'll be following the build.

@ricardozanini
Copy link
Member Author

ricardozanini commented Dec 28, 2023

@ricardozanini great, I'll be following the build.

https://ci-builds.apache.org/blue/organizations/jenkins/KIE%2Fkogito%2Fmain%2Fpullrequest%2Fkogito-images.build-image/activity/

Once we remove the unsupported images these runs should be way lighter.

Signed-off-by: Ricardo Zanini <[email protected]>
@apache apache deleted a comment from kie-ci3 Dec 28, 2023
@apache apache deleted a comment from kie-ci3 Dec 28, 2023
@apache apache deleted a comment from kie-ci3 Dec 28, 2023
@apache apache deleted a comment from kie-ci3 Dec 28, 2023
@porcelli porcelli merged commit 685474f into apache:main Dec 28, 2023
4 checks passed
@porcelli
Copy link
Contributor

thank you @ricardozanini for this huge effort!

rgdoliveira pushed a commit to rgdoliveira/incubator-kie-kogito-images that referenced this pull request Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade Maven to 3.9.3 and Quarkus 3
6 participants