Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue-589 Holistic review of non-quarkus core concepts guides #615

Merged
merged 2 commits into from
Apr 8, 2024

Conversation

barboras7
Copy link
Contributor

Closes/Fixes/Resolves #589

Description:
The PR contains fixes in Serverless Workflow Specification part in the Core Concepts chapter. If some issues will be found in other parts of this chapter, a seperate issue will be created to keep this PR clean.
This PR reorders the items in the implementation status tables so that it is more user friendly (now it is in alphabetical order instead of random)

Please make sure that your PR meets the following requirements:

  • You have read the contributions doc
  • Pull Request title is properly formatted: Issue-XYZ Subject
  • Pull Request title contains the target branch if not targeting main: [0.9.x] Issue-XYZ Subject
  • The nav.adoc file has a link to this guide in the proper category
  • The index.adoc file has a card to this guide in the proper category, with a meaningful description
How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

@barboras7 barboras7 requested a review from domhanak as a code owner April 5, 2024 10:19
Copy link
Contributor

github-actions bot commented Apr 5, 2024

🎊 PR Preview 0d13994 has been successfully built and deployed. See the documentation preview: https://sonataflow-docs-preview-pr-615.surge.sh

@domhanak domhanak requested a review from tomasdavidorg April 5, 2024 11:39
Copy link
Contributor

@domhanak domhanak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks you!

Copy link
Contributor

@tomasdavidorg tomasdavidorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small comment. Thanks 🙂

…kflow-specification-support.adoc

Co-authored-by: Tomáš David <[email protected]>
@tomasdavidorg tomasdavidorg merged commit 0f4831a into apache:main Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Holistic review of non-quarkus core concepts guides
3 participants