Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove push action from build action / verify preview run #559

Merged
merged 2 commits into from
Mar 6, 2024

Conversation

ricardozanini
Copy link
Member

Closes/Fixes/Resolves #ISSUE-NUMBER

Description:
Small PR to verify if the preview actions are working and fixing it.

Relates to #539

Please make sure that your PR meets the following requirements:

  • You have read the contributions doc
  • Pull Request title is properly formatted: Issue-XYZ Subject
  • Pull Request title contains the target branch if not targeting main: [0.9.x] Issue-XYZ Subject
  • The nav.adoc file has a link to this guide in the proper category
  • The index.adoc file has a card to this guide in the proper category, with a meaningful description
How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

@ricardozanini ricardozanini requested a review from krisv as a code owner March 6, 2024 17:16
@ricardozanini
Copy link
Member Author

Ok, we need more work from Infra to get this going since we are missing the PAT token in the download action run: https://github.com/actions/download-artifact?tab=readme-ov-file#download-artifacts-from-other-workflow-runs-or-repositories

@ricardozanini ricardozanini requested a review from domhanak March 6, 2024 17:29
@ricardozanini
Copy link
Member Author

@domhanak merging since we need to verify that after the workflow is updated on main. Really annoying.

@ricardozanini ricardozanini merged commit bd5a4a9 into apache:main Mar 6, 2024
2 checks passed
@ricardozanini ricardozanini deleted the no-issue-fix-preview branch March 6, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant