Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KOGITO-7413] Adding custom rest #541

Merged
merged 4 commits into from
Feb 21, 2024
Merged

Conversation

fjtirado
Copy link
Contributor

@fjtirado fjtirado commented Feb 19, 2024

Closes/Fixes/Resolves https://issues.redhat.com/browse/KOGITO-7413

Description:

Please make sure that your PR meets the following requirements:

  • You have read the contributions doc
  • Pull Request title is properly formatted: Issue-XYZ Subject
  • Pull Request title contains the target branch if not targeting main: [0.9.x] Issue-XYZ Subject
  • The nav.adoc file has a link to this guide in the proper category
  • The index.adoc file has a card to this guide in the proper category, with a meaningful description
How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

@ricardozanini
Copy link
Member

@kaldesai can you ptal?

@kaldesai
Copy link
Contributor

@kaldesai can you ptal?

Sure!

Copy link
Contributor

@kaldesai kaldesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few small suggestions. Otherwise, your content looks good to me. Thank you!

Copy link
Contributor

@domhanak domhanak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@domhanak
Copy link
Contributor

Applied suggestions from @kaldesai all looked good to me

@ricardozanini
Copy link
Member

One minor thing there

@fjtirado fjtirado merged commit 10b27e5 into apache:main Feb 21, 2024
1 check passed
domhanak added a commit to domhanak/kogito-docs that referenced this pull request Feb 27, 2024
* [KOGITO-7413] Adding custom rest

* [KOGITO-7413] Gonzaloś comment.

* Apply  Kalyanis suggestions from code review

Co-authored-by: Kalyani Desai <[email protected]>

* Update serverlessworkflow/modules/ROOT/pages/core/custom-functions-support.adoc

Co-authored-by: Ricardo Zanini <[email protected]>

---------

Co-authored-by: Dominik Hanák <[email protected]>
Co-authored-by: Kalyani Desai <[email protected]>
Co-authored-by: Ricardo Zanini <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants