-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[KOGITO-7413] Adding custom rest #541
Conversation
serverlessworkflow/modules/ROOT/pages/core/custom-functions-support.adoc
Outdated
Show resolved
Hide resolved
@kaldesai can you ptal? |
Sure! |
serverlessworkflow/modules/ROOT/pages/core/custom-functions-support.adoc
Outdated
Show resolved
Hide resolved
serverlessworkflow/modules/ROOT/pages/core/custom-functions-support.adoc
Outdated
Show resolved
Hide resolved
serverlessworkflow/modules/ROOT/pages/core/custom-functions-support.adoc
Outdated
Show resolved
Hide resolved
serverlessworkflow/modules/ROOT/pages/core/custom-functions-support.adoc
Outdated
Show resolved
Hide resolved
serverlessworkflow/modules/ROOT/pages/core/custom-functions-support.adoc
Outdated
Show resolved
Hide resolved
serverlessworkflow/modules/ROOT/pages/core/custom-functions-support.adoc
Outdated
Show resolved
Hide resolved
serverlessworkflow/modules/ROOT/pages/core/custom-functions-support.adoc
Outdated
Show resolved
Hide resolved
serverlessworkflow/modules/ROOT/pages/core/custom-functions-support.adoc
Outdated
Show resolved
Hide resolved
serverlessworkflow/modules/ROOT/pages/core/custom-functions-support.adoc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a few small suggestions. Otherwise, your content looks good to me. Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
Co-authored-by: Kalyani Desai <[email protected]>
Applied suggestions from @kaldesai all looked good to me |
serverlessworkflow/modules/ROOT/pages/core/custom-functions-support.adoc
Outdated
Show resolved
Hide resolved
One minor thing there |
…pport.adoc Co-authored-by: Ricardo Zanini <[email protected]>
* [KOGITO-7413] Adding custom rest * [KOGITO-7413] Gonzaloś comment. * Apply Kalyanis suggestions from code review Co-authored-by: Kalyani Desai <[email protected]> * Update serverlessworkflow/modules/ROOT/pages/core/custom-functions-support.adoc Co-authored-by: Ricardo Zanini <[email protected]> --------- Co-authored-by: Dominik Hanák <[email protected]> Co-authored-by: Kalyani Desai <[email protected]> Co-authored-by: Ricardo Zanini <[email protected]>
Closes/Fixes/Resolves https://issues.redhat.com/browse/KOGITO-7413
Description:
Please make sure that your PR meets the following requirements:
Issue-XYZ Subject
[0.9.x] Issue-XYZ Subject
How to backport a pull request to a different branch?
In order to automatically create a backporting pull request please add one or more labels having the following format
backport-<branch-name>
, where<branch-name>
is the name of the branch where the pull request must be backported to (e.g.,backport-7.67.x
to backport the original PR to the7.67.x
branch).Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.
If something goes wrong, the author will be notified and at this point a manual backporting is needed.