[KOGITO-9982] Add persistence to SonataFlow CRD #529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardozanini
requested review from
ricardozanini and
jakubschwan
and removed request for
MarianMacik
|
@kaldesai can you please review? |
kaldesai
reviewed
Feb 7, 2024
serverlessworkflow/modules/ROOT/pages/cloud/operator/using-persistence.adoc
Outdated
Show resolved
Hide resolved
kaldesai
reviewed
Feb 7, 2024
serverlessworkflow/modules/ROOT/pages/cloud/operator/using-persistence.adoc
Outdated
Show resolved
Hide resolved
kaldesai
reviewed
Feb 7, 2024
serverlessworkflow/modules/ROOT/pages/cloud/operator/using-persistence.adoc
Outdated
Show resolved
Hide resolved
kaldesai
reviewed
Feb 7, 2024
| KanikoBuildCacheEnabled: "true" | ||
| --- | ||
|
|
||
| The values of `POSTGRES_USER` and `POSTGRES_PASSWORD` are the keys in the secret that contains the credentials to connect to the postgreSQL instance. |
There was a problem hiding this comment.
Suggested change
| The values of `POSTGRES_USER` and `POSTGRES_PASSWORD` are the keys in the secret that contains the credentials to connect to the postgreSQL instance. | |
| The values of `POSTGRES_USER` and `POSTGRES_PASSWORD` are the secret keys containing the credentials to connect to the PostgreSQL instance. |
There was a problem hiding this comment.
I'm not sure because this change conveys that the keys are a secret, when in fact the keys are not a secret but are stored in an object of kind secret. It's a kubernetes terminology.
There was a problem hiding this comment.
imho we can add the link:
...are the keys in the [secret](https://kubernetes.io/docs/concepts/configuration/secret/)
kaldesai
reviewed
Feb 7, 2024
serverlessworkflow/modules/ROOT/pages/cloud/operator/using-persistence.adoc
Outdated
Show resolved
Hide resolved
kaldesai
reviewed
Feb 7, 2024
serverlessworkflow/modules/ROOT/pages/cloud/operator/using-persistence.adoc
Outdated
Show resolved
Hide resolved
kaldesai
approved these changes
Feb 7, 2024
|
I'll hold the PR until the development PR is merged. |
7 tasks
|
@jordigilh you are missing in desired chapter |
jordigilh
force-pushed
the
kogito_9982_add_persistence_workflow_crd
branch
3 times, most recently
from
9928cfb to
0bf9b41
Compare
domhanak
approved these changes
Mar 11, 2024
wmedvede
approved these changes
Mar 11, 2024
|
@jordigilh can you please rebase? |
Signed-off-by: Jordi Gil <[email protected]>
Signed-off-by: Jordi Gil <[email protected]>
Signed-off-by: Jordi Gil <[email protected]>
jordigilh
force-pushed
the
kogito_9982_add_persistence_workflow_crd
branch
from
0bf9b41 to
e6eb8c0
Compare
Done |
|
🎊 PR Preview cca2382 has been successfully built and deployed. See the documentation preview: https://sonataflow-docs-preview-pr-529.surge.sh |
ricardozanini
approved these changes
Mar 11, 2024
There was a problem hiding this comment.
Small suggestions that we can batch accept and merge. Many thanks for this, @jordigilh!
serverlessworkflow/modules/ROOT/pages/cloud/operator/using-persistence.adoc
Outdated
Show resolved
Hide resolved
serverlessworkflow/modules/ROOT/pages/cloud/operator/using-persistence.adoc
Outdated
Show resolved
Hide resolved
serverlessworkflow/modules/ROOT/pages/cloud/operator/using-persistence.adoc
Outdated
Show resolved
Hide resolved
serverlessworkflow/modules/ROOT/pages/cloud/operator/using-persistence.adoc
Outdated
Show resolved
Hide resolved
serverlessworkflow/modules/ROOT/pages/cloud/operator/using-persistence.adoc
Outdated
Show resolved
Hide resolved
…sistence.adoc Co-authored-by: Ricardo Zanini <[email protected]>
…sistence.adoc Co-authored-by: Ricardo Zanini <[email protected]>
…sistence.adoc Co-authored-by: Ricardo Zanini <[email protected]>
…sistence.adoc Co-authored-by: Ricardo Zanini <[email protected]>
…sistence.adoc Co-authored-by: Ricardo Zanini <[email protected]>
|
@ricardozanini thanks for the suggestions! I've merged them to this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds documentation with examples on how to configure a
SonataFlowCR with persistence using its own dedicatedpersistencefield or leveraging on theSonataFlowPlatformCR persistence configuration.@ricardozanini @wmedvede @caponetto PTAL.