-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KOGITO-9971: [Guides] Dataindex deployment use cases with operator #519
Conversation
does this use the new built-in data index deployment capabilities we've added to the operator? fyi, in case you hadn't seen or used it yet. granted, not sure when a new release will occur that would make this feature available |
This use cases were done before that new feature, so the answer is no. For the moment they are showing a way to see that deployments working, and I think those use cases will need to be updated including that new feature you commented and that will be reflected in the doc as well. @ricardozanini WDYT? |
serverlessworkflow/modules/ROOT/pages/data-index/data-index-usecase-multi.adoc
Show resolved
Hide resolved
serverlessworkflow/modules/ROOT/pages/data-index/data-index-usecase-singleton.adoc
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now we need to be creative and incorporate the use cases' sandbox repo here instead of linking to it.
|
||
* kogito-addons-quarkus-data-index-persistence-postgresql | ||
* kogito-addons-quarkus-data-index-persistence-infinispan | ||
* kogito-addons-quarkus-data-index-persistence-mongodb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a little description of each?
serverlessworkflow/modules/ROOT/pages/data-index/data-index-quarkus-extension.adoc
Outdated
Show resolved
Hide resolved
serverlessworkflow/modules/ROOT/pages/data-index/data-index-quarkus-extension.adoc
Outdated
Show resolved
Hide resolved
serverlessworkflow/modules/ROOT/pages/data-index/data-index-usecase-multi.adoc
Outdated
Show resolved
Hide resolved
serverlessworkflow/modules/ROOT/pages/data-index/data-index-usecase-multi.adoc
Show resolved
Hide resolved
serverlessworkflow/modules/ROOT/pages/data-index/data-index-usecase-singleton.adoc
Show resolved
Hide resolved
@ricardozanini removed the ref to usecases repo and put the dataindex deployment related kustomization resources in detail. While we are waiting for the change the doc to link the new feature about the dataindex deployment reference. could you take a look? Thanks! |
serverlessworkflow/modules/ROOT/pages/data-index/data-index-usecase-multi.adoc
Outdated
Show resolved
Hide resolved
serverlessworkflow/modules/ROOT/pages/data-index/data-index-usecase-singleton.adoc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some steps that are expecting something that does not exist, we need to include these in the guides.
serverlessworkflow/modules/ROOT/pages/data-index/common/_dataindex_deployment_operator.adoc
Show resolved
Hide resolved
serverlessworkflow/modules/ROOT/pages/data-index/common/_dataindex_deployment_operator.adoc
Outdated
Show resolved
Hide resolved
I've added the referenced use cases to our official example here apache/incubator-kie-kogito-examples#1839 and modified the guides links to that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @nmirasch ,
I checked Data Index Quarkus extensions section (data-index-quarkus-extension.adoc file) and I have a few minor comments.
There is missing an explanation, what is the difference between "Quarkus Data Index" and "Quarkus Data Index persistence" extensions.
The referenced "PostgreSQL Configuration" section does not contain all necessary information about how to configure the database properly.
Thanks!
jira: https://issues.redhat.com/browse/KOGITO-9971
Please make sure that your PR meets the following requirements:
KOGITO-XYZ Subject
[0.9.x] KOGITO-XYZ Subject
How to backport a pull request to a different branch?
In order to automatically create a backporting pull request please add one or more labels having the following format
backport-<branch-name>
, where<branch-name>
is the name of the branch where the pull request must be backported to (e.g.,backport-7.67.x
to backport the original PR to the7.67.x
branch).Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.
If something goes wrong, the author will be notified and at this point a manual backporting is needed.