-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[KOGITO-9839] - Add how to build a custom devmode image #508
Conversation
Signed-off-by: Ricardo Zanini <[email protected]>
serverlessworkflow/modules/ROOT/pages/cloud/operator/building-custom-images.adoc
Outdated
Show resolved
Hide resolved
serverlessworkflow/modules/ROOT/pages/cloud/operator/building-custom-images.adoc
Outdated
Show resolved
Hide resolved
serverlessworkflow/modules/ROOT/pages/cloud/operator/building-custom-images.adoc
Outdated
Show resolved
Hide resolved
serverlessworkflow/modules/ROOT/pages/cloud/operator/building-custom-images.adoc
Outdated
Show resolved
Hide resolved
COPY requirements.txt /home/kogito/serverless-workflow-project/ <6> | ||
|
||
RUN pip install numpy | ||
RUN pip install -r requirements.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why copy the requirements if it is used only on build time, it seems?
.Example of building a custom dev mode image | ||
[source,shell,subs="attributes+"] | ||
---- | ||
docker build -t quay.io/acme/sonataflow-python-devmode:latest . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe enforce podman and Containerfile instead Dockerfile?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd rather stay with Docker since it's what we have on the operator side
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I've added a silly suggestion that I believe can be good for people having a direct link to know how the just generated image can be used. Take a look in case it makes sense to you too.
serverlessworkflow/modules/ROOT/pages/cloud/operator/building-custom-images.adoc
Show resolved
Hide resolved
serverlessworkflow/modules/ROOT/pages/cloud/operator/building-custom-images.adoc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ricardozanini LGTM
Co-authored-by: Filippe Spolti <[email protected]> Co-authored-by: Kalyani Desai <[email protected]> Co-authored-by: Walter Medvedeo <[email protected]>
JIRA:
https://issues.redhat.com/browse/KOGITO-9839
Description:
In this PR, we add a new guide explaining how to build a custom devmode image. Please note that the idea is to expand this very same guide to final workflow images and quarkus builds too.
Please make sure that your PR meets the following requirements:
KOGITO-XYZ Subject
[0.9.x] KOGITO-XYZ Subject
How to backport a pull request to a different branch?
In order to automatically create a backporting pull request please add one or more labels having the following format
backport-<branch-name>
, where<branch-name>
is the name of the branch where the pull request must be backported to (e.g.,backport-7.67.x
to backport the original PR to the7.67.x
branch).Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.
If something goes wrong, the author will be notified and at this point a manual backporting is needed.