-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[KOGITO-9265] Add PodSpec customization guide #506
Conversation
sonataflow.org/version: 0.0.1 | ||
spec: | ||
podTemplate: <1> | ||
container: <2> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so the container
instead of containers
is a deviation on purpose from k8s podTemplate right?
|
||
=== Setting a custom image in production | ||
|
||
When xref:cloud/operator/build-and-deploy-workflows.adoc[deploying in production], you can opt in to have the operator to handle the build process for you. However, in more complex scenarios it's expected that the user owns and controls the build process. For this reason, when overriding the image the operator won't build the workflow. The operator will try to deploy the workflow using the given image. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will the rest of the spec.resources be mounted into that container at runtime? this is defintely the expectation.
In other words it should automatically populate the volumes list in the template.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @rgolangh! We can, though it won't at this moment. We should discuss this use case since we don't have a build, hence the resource won't be in the application's classpath (included in the jar). We should definitely understand where to mount these resources in this situation.
I'll add a note about this in this PR.
I've opened a JIRA for us to discuss: https://issues.redhat.com/browse/KOGITO-9845
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Signed-off-by: Ricardo Zanini <[email protected]>
Signed-off-by: Ricardo Zanini <[email protected]>
Signed-off-by: Ricardo Zanini <[email protected]>
061da72
to
d8ad468
Compare
JIRA:
https://issues.redhat.com/browse/KOGITO-9265
Description:
In this PR, we add a new guide to explain the new feature able to customize PodSpec in SonataFlow CR.
Depends on:
Please make sure that your PR meets the following requirements:
KOGITO-XYZ Subject
[0.9.x] KOGITO-XYZ Subject
How to backport a pull request to a different branch?
In order to automatically create a backporting pull request please add one or more labels having the following format
backport-<branch-name>
, where<branch-name>
is the name of the branch where the pull request must be backported to (e.g.,backport-7.67.x
to backport the original PR to the7.67.x
branch).Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.
If something goes wrong, the author will be notified and at this point a manual backporting is needed.