-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DMN Runner execution identifies wrongly missing requirements #270
Comments
I investigate it a little, the problem is in the response of the JIT Executor. Not sure why this is happening but the |
yes, as stated above, the issue, really seems to be in because if we check the typescript code in public async result(payload: ExtendedServicesModelPayload): Promise<ExtendedServicesDmnResult> {
if (!this.isPayloadValid(payload)) {
return { messages: [] };
}
const response = await fetch(this.DMN_JIT_EXECUTOR_DMN_RESULT_URL, {
method: "POST",
headers: {
"Content-Type": "application/json",
Accept: "application/json, text/plain, */*",
},
body: JSON.stringify(payload),
});
const txt = await response.json();
console.error("plain text to check: " + JSON.stringify(txt))
return txt;
} |
…rements Closes: apache/incubator-kie-issues#270 The problem was not in the DMN Runne rui component but in the engine that executes the validation. The mechanism for storing messages contained a bug. ``` @OverRide public DMNMessage addMessage(DMNMessage newMessage) { for( DMNMessage existingMessage : messages ) { if( isDuplicate( existingMessage, newMessage ) ) { return existingMessage; } } this.messages.add( newMessage ); return newMessage; } ``` `isDuplicate` didn't take into account all needed attributes of the `message`
…rements Closes: apache/incubator-kie-issues#270 The problem was not in the DMN Runne rui component but in the engine that executes the validation. The mechanism for storing messages contained a bug. ``` @OverRide public DMNMessage addMessage(DMNMessage newMessage) { for( DMNMessage existingMessage : messages ) { if( isDuplicate( existingMessage, newMessage ) ) { return existingMessage; } } this.messages.add( newMessage ); return newMessage; } ``` `isDuplicate` didn't take into account all needed attributes of the `message`
…rements Closes: apache/incubator-kie-issues#270 The problem was not in the DMN Runne rui component but in the engine that executes the validation. The mechanism for storing messages contained a bug. ``` @OverRide public DMNMessage addMessage(DMNMessage newMessage) { for( DMNMessage existingMessage : messages ) { if( isDuplicate( existingMessage, newMessage ) ) { return existingMessage; } } this.messages.add( newMessage ); return newMessage; } ``` `isDuplicate` didn't take into account all needed attributes of the `message`
…rements Closes: apache/incubator-kie-issues#270 The problem was not in the DMN Runne rui component but in the engine that executes the validation. The mechanism for storing messages contained a bug. ``` @OverRide public DMNMessage addMessage(DMNMessage newMessage) { for( DMNMessage existingMessage : messages ) { if( isDuplicate( existingMessage, newMessage ) ) { return existingMessage; } } this.messages.add( newMessage ); return newMessage; } ``` `isDuplicate` didn't take into account all needed attributes of the `message`
…rements Closes: apache/incubator-kie-issues#270 The problem was not in the DMN Runne rui component but in the engine that executes the validation. The mechanism for storing messages contained a bug. ``` @OverRide public DMNMessage addMessage(DMNMessage newMessage) { for( DMNMessage existingMessage : messages ) { if( isDuplicate( existingMessage, newMessage ) ) { return existingMessage; } } this.messages.add( newMessage ); return newMessage; } ``` `isDuplicate` didn't take into account all needed attributes of the `message`
…rements Closes: apache/incubator-kie-issues#270 The problem was not in the DMN Runne rui component but in the engine that executes the validation. The mechanism for storing messages contained a bug. ``` @OverRide public DMNMessage addMessage(DMNMessage newMessage) { for( DMNMessage existingMessage : messages ) { if( isDuplicate( existingMessage, newMessage ) ) { return existingMessage; } } this.messages.add( newMessage ); return newMessage; } ``` `isDuplicate` didn't take into account all needed attributes of the `message`
…rements Closes: apache/incubator-kie-issues#270 The problem was not in the DMN Runne rui component but in the engine that executes the validation. The mechanism for storing messages contained a bug. ``` @OverRide public DMNMessage addMessage(DMNMessage newMessage) { for( DMNMessage existingMessage : messages ) { if( isDuplicate( existingMessage, newMessage ) ) { return existingMessage; } } this.messages.add( newMessage ); return newMessage; } ``` `isDuplicate` didn't take into account all needed attributes of the `message`
…rements Closes: apache/incubator-kie-issues#270 The problem was not in the DMN Runner ui component but in the engine that executes the validation. The mechanism for storing messages includes filtering of messages. however this filtering inappropriately assumed messages bellow like equal: - Reqiured dependency 'A' not found on node 'N' - Required dependency 'B' not found on ndoe 'N' ``` @OverRide public DMNMessage addMessage(DMNMessage newMessage) { for( DMNMessage existingMessage : messages ) { if( isDuplicate( existingMessage, newMessage ) ) { return existingMessage; } } this.messages.add( newMessage ); return newMessage; } ``` `isDuplicate` didn't take into account all needed attributes of the `message` We decided to add option to turn off this filtering of messages on backround. As part of this PR we turn it of only for `DMNResultImpl`. We keep it unchanged on other places.
@jomarko Is this fixed? I saw there was a PR (apache/incubator-kie-drools#5461) that was merged already.. Maybe we can close this issue? |
Hi @tiagobento , sorry for a late response, I rechecked the #270 with 0.32.0 prerelease yes, the drools PR was merged, however the fix is not visible kie-tools, probably, because:
So think these options are possible
What is your suggestion please? |
As explained above, the issues is not in DMN Runner itself however now in dependencies of kie-tools, we will finish the complete fix via #634 |
Steps to reproduce
habitability.dmn.txt
[1]
[2]
The text was updated successfully, but these errors were encountered: