Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tapd): add more log when converting unicode #8164

Merged
merged 2 commits into from
Oct 30, 2024
Merged

feat(tapd): add more log when converting unicode #8164

merged 2 commits into from
Oct 30, 2024

Conversation

d4x1
Copy link
Contributor

@d4x1 d4x1 commented Oct 30, 2024

⚠️ Pre Checklist

Please complete ALL items in this checklist, and remove before submitting

  • I have read through the Contributing Documentation.
  • I have added relevant tests.
  • I have added relevant documentation.
  • I will add labels to the PR, such as pr-type/bug-fix, pr-type/feature-development, etc.

Summary

What does this PR do?
Log the context info when errors occur in tapd plugin.

Does this close any open issues?

Closes N/A

Screenshots

Include any relevant screenshots here.

Other Information

Any other information that is important to this PR.

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Oct 30, 2024
@dosubot dosubot bot added component/plugins This issue or PR relates to plugins pr-type/feature-development This PR is to develop a new feature labels Oct 30, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 30, 2024
@d4x1 d4x1 merged commit ded45ae into main Oct 30, 2024
11 checks passed
@d4x1 d4x1 deleted the dev-1030 branch October 30, 2024 09:07
github-actions bot pushed a commit that referenced this pull request Oct 30, 2024
* feat(tapd): add more log when converting unicode

* feat(tapd): ignore errors when converting unicode fails
Copy link

🤖 Target: #release-v0.21 cherry pick finished successfully 🎉!

@github-actions github-actions bot added the bot/auto-cherry-pick-completed auto cherry pick completed label Oct 30, 2024
github-actions bot pushed a commit that referenced this pull request Oct 30, 2024
* feat(tapd): add more log when converting unicode

* feat(tapd): ignore errors when converting unicode fails
Copy link

🤖 Target: #release-v1.0 cherry pick finished successfully 🎉!

d4x1 added a commit that referenced this pull request Oct 30, 2024
* feat(tapd): add more log when converting unicode

* feat(tapd): ignore errors when converting unicode fails

Co-authored-by: Lynwee <[email protected]>
d4x1 added a commit that referenced this pull request Oct 30, 2024
* feat(tapd): add more log when converting unicode

* feat(tapd): ignore errors when converting unicode fails

Co-authored-by: Lynwee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot/auto-cherry-pick-completed auto cherry pick completed component/plugins This issue or PR relates to plugins lgtm This PR has been approved by a maintainer needs-cherrypick-v0.21 needs-cherrypick-v1.0 pr-type/feature-development This PR is to develop a new feature size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants