Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adjust some content for github app #8036

Merged
merged 1 commit into from
Sep 13, 2024
Merged

feat: adjust some content for github app #8036

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion config-ui/src/plugins/components/connection-form/fields/endpoint.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ export const ConnectionEndpoint = ({
if (multipleVersions) {
return (
<>
<Block title={name} required>
<Block title={`${name} Version`} required>
<Radio.Group value={version} onChange={handleChange}>
<Radio value="cloud">{name} Cloud</Radio>
<Radio value="server" disabled={!multipleVersions.server}>
Expand Down
6 changes: 3 additions & 3 deletions config-ui/src/plugins/register/github/connection-fields/authentication.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,10 @@ export const Authentication = ({ initialValue, value, setValue }: Props) => {
}, [initialValue]);

return (
<Block title="Authentication type" required>
<Block title="Authentication Type" required>
<Radio.Group value={value || initialValue} onChange={(e) => setValue(e.target.value)}>
<Radio value="AccessToken">Github Access Token</Radio>
<Radio value="AppKey">Github App</Radio>
<Radio value="AccessToken">GitHub Access Token</Radio>
<Radio value="AppKey">GitHub App(Beta)</Radio>
</Radio.Group>
</Block>
);
Expand Down
7 changes: 4 additions & 3 deletions config-ui/src/plugins/register/github/connection-fields/githubapp.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,12 +139,13 @@ export const GithubApp = ({ endpoint, proxy, initialValue, value, error, setValu

return (
<Block
title="Github App settings"
title="GitHub App Settings"
description={
<>
Input information about your Github App{' '}
GitHub App token expires every hour. To collect large resposities, please choose the GitHub Access Token to
authenticate.{' '}
<ExternalLink link="https://docs.github.com/en/apps/maintaining-github-apps/modifying-a-github-app-registration#navigating-to-your-github-app-settings">
Learn how to create a github app
Learn how to create a GitHub App
</ExternalLink>
</>
}
Expand Down
Loading