feat: add ENV_FILE var #5399
Merged
feat: add ENV_FILE var #5399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keon94
reviewed
Jun 7, 2023
| if envFile := os.Getenv("ENV_FILE"); envFile != "" { | ||
| v.SetConfigFile(envFile) | ||
| } else { | ||
| v.SetConfigFile("./.env") |
There was a problem hiding this comment.
@abeizn Is there a reason to just default to the current dir? I'd have kept the list of parent paths as before:
i.e.
v.AddConfigPath("./../../.env")
v.AddConfigPath("./../.env")
//etcThere was a problem hiding this comment.
@keon94 You are right, according to klesh’s opinion, delete all other paths and only keep the current path, but it seems that it cannot be used so easily
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
feat: add ENV_FILE var
Does this close any open issues?
Closes #5235
Screenshots
Include any relevant screenshots here.
Other Information
Any other information that is important to this PR.