fix(zentao): make sure connection uncacheable

backend/core/plugin/plugin_datasource.go

@@ -41,6 +41,11 @@ type CacheableConnection interface {
 	GetHash() string
 }
 
+type UnCacheableConnection interface {
+	ApiConnection
+	UncCacheable() bool
+}
+
 // ApiAuthenticator is to be implemented by a Concreate Connection if Authorization is required
 type ApiAuthenticator interface {
 	// SetupAuthentication is a hook function for connection to set up authentication for the HTTP request

backend/helpers/pluginhelper/api/ds_remote_api_proxy_api.go

@@ -67,11 +67,15 @@ func (rap *DsRemoteApiProxyHelper[C]) prepare(input *plugin.ApiResourceInput) (*
 func (rap *DsRemoteApiProxyHelper[C]) getApiClient(connection *C) (*ApiClient, errors.Error) {
 	c := interface{}(connection)
 	key := ""
+	var cacheable bool = false
+	if unCacheableConnection, ok := c.(plugin.UnCacheableConnection); ok {
+		cacheable = !unCacheableConnection.UncCacheable()
+	}
 	if cacheableConn, ok := c.(plugin.CacheableConnection); ok {
 		key = cacheableConn.GetHash()
 	}
 	// try to reuse api client
-	if key != "" {
+	if key != "" && cacheable {
 		rap.httpClientCacheMutex.RLock()
 		client, ok := rap.httpClientCache[key]
 		rap.httpClientCacheMutex.RUnlock()
@@ -86,7 +90,7 @@ func (rap *DsRemoteApiProxyHelper[C]) getApiClient(connection *C) (*ApiClient, e
 		return nil, err
 	}
 	// cache the client if key is not empty
-	if key != "" {
+	if key != "" && cacheable {
 		rap.httpClientCacheMutex.Lock()
 		rap.httpClientCache[key] = client
 		rap.httpClientCacheMutex.Unlock()

backend/plugins/zentao/models/connection.go

@@ -73,6 +73,11 @@ type ZentaoConn struct {
 	DbMaxConns     int    `json:"dbMaxConns" mapstructure:"dbMaxConns"`
 }
 
+func (connection ZentaoConn) UncCacheable() bool {
+	// zentao's token will expire after about 24min, so api client cannot be cached.
+	return true
+}
+
 func (connection ZentaoConn) Sanitize() ZentaoConn {
 	connection.Password = ""
 	if connection.DbUrl != "" {
@@ -106,6 +111,10 @@ func (connection ZentaoConn) SanitizeDbUrl() string {
 	return dbUrl
 }
 
+func (connection ZentaoConnection) UncCacheable() bool {
+	return connection.ZentaoConn.UncCacheable()
+}
+
 func (connection ZentaoConnection) Sanitize() ZentaoConnection {
 	connection.ZentaoConn = connection.ZentaoConn.Sanitize()
 	return connection