Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled replicaCount #269

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

angelsanchezdck
Copy link

Enables the ability to set replicas of StatefulSet and deployments to 0, fully disabling the devlake-helm-chart. This ensures compliance with the requirement of having only one replica for deployments in dev-lake, providing finer control over the development environment.

Issue: #266

Copy link
Contributor

@ZhangNing10 ZhangNing10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @angelsanchezdck , thanks for creating the pr!
Different deployments/statefulset uses different values, for example .Values.lake.replicaCount. Then you can delete the values.replicaCount part in values.yaml

@angelsanchezdck
Copy link
Author

Hi @ZhangNing10 , Done!

ui: No limit
dev-lake and mysql: replicaCount is limited to 0 or 1

ZhangNing10
ZhangNing10 previously approved these changes Jun 18, 2024
Copy link
Contributor

@ZhangNing10 ZhangNing10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZhangNing10
Copy link
Contributor

hi @angelsanchezdck , thanks a lot! could you kindly fix the conflict?

@angelsanchezdck
Copy link
Author

Sorry for late.

@angelsanchezdck
Copy link
Author

What is the next step?

@ZhangNing10
Copy link
Contributor

Copy link
Contributor

@ZhangNing10 ZhangNing10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @angelsanchezdck , the imageTag should not be changed, kindly keep the same as main branch

# replica count
replicaCount: 1
imageTag: v1.0.1
imageTag: v1.0.0-beta3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the imageTag should not be changed, keep the same as main branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants