-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate config/effector descriptions for yaml-only blueprints #1176
base: master
Are you sure you want to change the base?
Conversation
LGTM. One comment though. This generate a JS file which encapsulates the JSON data into a JS var. While this is ok for the documentation as it imports the file directly, it's a bit tedious to share the info with other services (i.e. community catalog) as we will need to |
.build(); | ||
jsonList.add(toJson(result)); | ||
} else if (!yaml.isEmpty()) { | ||
LocalManagementContext lmgmt = new LocalManagementContext(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will read config from the user's brooklyn.properties
. Better initialize it with an empty state using new LocalManagementContext(BrooklynProperties.Factory.newEmpty());
782e2b7
to
186c175
Compare
Jenkins fails due to |
186c175
to
aab2fc9
Compare
@bostko Didn't notice that. Let's not reintroduce a slow process then. However, I quite like the @iyovcheva's idea of generate the |
test failure is clearly unrelated, maybe close and reopen to run again. meanwhile we should look at this /cc @aledsage :
|
(easily fixed - the test was doing an immediate assert on something happening in another thread; PR to follow; @iyovcheva give it an hour or so for the other fix to land then please close+reopen this to run the jenkins tests again) |
aab2fc9
to
7774e46
Compare
7774e46
to
e6d8fb2
Compare
No description provided.