-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IGNITE-23338 Reduce number of intermediate serializations in Compute #4778
Open
valepakh
wants to merge
1
commit into
apache:main
Choose a base branch
from
unisonteam:IGNITE-23338
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
58 changes: 58 additions & 0 deletions
58
modules/core/src/main/java/org/apache/ignite/internal/compute/ComputeJobArgumentHolder.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,58 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.ignite.internal.compute; | ||
|
|
||
| /** | ||
| * Holds unmarshalled binary data for the compute, used for the optimization to reduce number of conversions in case when thin client | ||
| * requests job execution on another job. In this case, the argument is packed on the client, unpacked as a binary data on the client | ||
| * handler node, passed as an object of this class to the remote node and only there it is unmarshalled. | ||
| */ | ||
| public class ComputeJobArgumentHolder { | ||
| private final ComputeJobType type; | ||
|
|
||
| private final byte[] data; | ||
|
|
||
| /** | ||
| * Constructs a holder. | ||
| * | ||
| * @param type Job argument type. | ||
| * @param data Marshalled data. | ||
| */ | ||
| public ComputeJobArgumentHolder(ComputeJobType type, byte[] data) { | ||
| this.type = type; | ||
| this.data = data; | ||
| } | ||
|
|
||
| /** | ||
| * Returns job argument type. | ||
| * | ||
| * @return Job argument type. | ||
| */ | ||
| public ComputeJobType type() { | ||
| return type; | ||
| } | ||
|
|
||
| /** | ||
| * Returns marshalled data. | ||
| * | ||
| * @return Marshalled data. | ||
| */ | ||
| public byte[] data() { | ||
| return data; | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we introduce a couple of new
ComputeJobTypes? The idea behindMARSHALLEDprefix is that is was really marshalled. But here we do not marshal the argument.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if
MARSHALLED_prefix is necessary.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe you are right. My idea was to add more information to the argument/result like "was this thing marshalled or not?". The answer to this question might be handy but most likely it will not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This identifiers are passed from the client when it packs the argument (and vice versa, when client handler packs the result).
So from the point of view of the client-to-node communication they are marshalled.
They are not marshalled, however, from the point of view of the node-to-node communication, which this ticket is about.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are two pieces of information: