Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API: Add UnknownType #12012

Merged
merged 7 commits into from
Jan 24, 2025
Merged

API: Add UnknownType #12012

merged 7 commits into from
Jan 24, 2025

Conversation

Fokko
Copy link
Contributor

@Fokko Fokko commented Jan 20, 2025

Fixes #11732

@Fokko Fokko requested a review from HonahX January 20, 2025 18:37
@HonahX HonahX linked an issue Jan 22, 2025 that may be closed by this pull request
Support UnknownType in API #12027
Closed
3 tasks
RussellSpitzer
RussellSpitzer approved these changes Jan 23, 2025
View reviewed changes
Copy link
Member

@RussellSpitzer RussellSpitzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok allowing Unknown in all these transforms and such, but I don't think we actually have a case where it can happen.

HonahX
HonahX approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@HonahX HonahX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

nastra
nastra approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@nastra nastra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one minor comment around testing

@Fokko Fokko merged commit a04220a into apache:main Jan 24, 2025
47 checks passed
@Fokko
Copy link
Contributor Author

Fokko commented Jan 24, 2025

Thanks @HonahX @RussellSpitzer and @nastra for the review 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HonahX HonahX HonahX approved these changes

@RussellSpitzer RussellSpitzer RussellSpitzer approved these changes

@nastra nastra nastra approved these changes

Assignees
No one assigned
Labels
API core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support UnknownType in API Support UnknownType for V3 Schema
4 participants
@Fokko @nastra @RussellSpitzer @HonahX