Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenAPI: Changes for freshness-aware table loading #11946

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

OpenAPI: Changes for freshness-aware table loading #11946

wants to merge 1 commit into from

Conversation

gaborkaszab
Copy link
Collaborator

Added ETag and If-None-Match headers and 304 response for table loading.

@gaborkaszab
Copy link
Collaborator Author

Based on this improvement proposal: https://docs.google.com/document/d/1rnVSP_iv2I47giwfAe-Z3DYhKkKwWCVvCkC9rEvtaLA

cc @danielcweeks

@jbonofre jbonofre self-requested a review January 13, 2025 16:39
@gaborkaszab
Copy link
Collaborator Author

Thanks for taking a look @danielcweeks ! I applied your suggested change.

dennishuo
dennishuo approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@dennishuo dennishuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, this will be very useful in catalog federation scenarios where a copy of metadata is intended to be stored on the federating catalog without sacrificing consistency for example in Apache Polaris' proposed flow for federation+migration to/from other Iceberg REST catalogs (https://docs.google.com/document/d/1Q6eEytxb0btpOPcL8RtkULskOlYUCo_3FLvFRnHkzBY/edit?tab=t.0#bookmark=id.dm0mcu9wuv09)

flyrain
flyrain reviewed Jan 23, 2025
View reviewed changes
Copy link
Contributor

@flyrain flyrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, left minor comments.

open-api/rest-catalog-open-api.yaml Outdated
schema:
type: string


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: remove the extra empty line?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

open-api/rest-catalog-open-api.yaml Outdated
etag:
name: ETag
in: header
description: Identifies a certain state of the table metadata.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is version more accurate here?

Suggested change
description: Identifies a certain state of the table metadata.
description: Identifies a unique version of the table metadata.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, suggestion applied

@gaborkaszab
OpenAPI: Changes for freshness-aware table loading
77d9666 
Added ETag and If-None-Match headers and 304 response for table loading.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HonahX HonahX HonahX approved these changes

@dennishuo dennishuo dennishuo approved these changes

@danielcweeks danielcweeks danielcweeks approved these changes

@flyrain flyrain flyrain approved these changes

@RussellSpitzer RussellSpitzer RussellSpitzer approved these changes

@jbonofre jbonofre Awaiting requested review from jbonofre

Assignees
No one assigned
Labels
OPENAPI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@gaborkaszab @RussellSpitzer @flyrain @danielcweeks @dennishuo @HonahX