Flink 1.20: Support default values in Parquet reader #11839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rdblue @pvary @RussellSpitzer I started to add default value support on Flink (Parquet). I'm working on the tests right now. |
|
@rdblue @pvary @RussellSpitzer I'm resuming the work on this PR (about the tests). |
|
@Fokko FYI, I'm working on the tests. I will update this PR soon. |
jbonofre
force-pushed
the
parquet-support-default-value-flink
branch
from
afddef5 to
bfac0c5
Compare
|
@rdblue @amogh-jahagirdar @RussellSpitzer @pvary I added tests for default value support in Flink. The PR is ready for review. Thanks for your patience 😄 |
rdblue
reviewed
Jan 22, 2025
flink/v1.20/flink/src/test/java/org/apache/iceberg/flink/data/TestFlinkParquetReader.java
Outdated
Show resolved
Hide resolved
rdblue
reviewed
Jan 22, 2025
flink/v1.20/flink/src/test/java/org/apache/iceberg/flink/data/TestFlinkParquetReader.java
Outdated
Show resolved
Hide resolved
rdblue
reviewed
Jan 22, 2025
flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/data/RowDataUtil.java
Outdated
Show resolved
Hide resolved
jbonofre
force-pushed
the
parquet-support-default-value-flink
branch
3 times, most recently
from
3d3c236 to
2b2915a
Compare
amogh-jahagirdar
approved these changes
Jan 23, 2025
There was a problem hiding this comment.
Had some non-blocking cleanup suggestions in the test, I'll wait a bit in case @rdblue had any other comments!
flink/v1.20/flink/src/test/java/org/apache/iceberg/flink/data/TestFlinkParquetReader.java
Outdated
Show resolved
Hide resolved
flink/v1.20/flink/src/test/java/org/apache/iceberg/flink/data/TestFlinkParquetReader.java
Outdated
Show resolved
Hide resolved
|
unrelated Flink 1.19 flaky test failure, I'll retrigger those checks for now |
jbonofre
force-pushed
the
parquet-support-default-value-flink
branch
from
2b2915a to
8421c4c
Compare
|
@amogh-jahagirdar I updated private |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.