feat(table): add conversion from Arrow Schema to Iceberg #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nastra
approved these changes
Oct 2, 2024
| {"test_partitioned_by_hours", iceberg.GreaterThanEqual(iceberg.Reference("ts"), "2023-03-05T00:00:00+00:00"), 8}, | ||
| {"test_partitioned_by_truncate", iceberg.GreaterThanEqual(iceberg.Reference("letter"), "e"), 8}, | ||
| {"test_partitioned_by_bucket", iceberg.GreaterThanEqual(iceberg.Reference("number"), int32(5)), 6}, | ||
| // for some reason when I run the provisioning locally i get 5 data files | ||
| // but GHA CI running spark provisioning ends up with only 4 files? | ||
| // anyone know why? |
There was a problem hiding this comment.
I forgot but what's correct here, 4 or 5 data files?
There was a problem hiding this comment.
It looks like my local runs now match the CI runs in generating 4 files so that seems correct to me.
Co-authored-by: Eduard Tudenhoefner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for adding Data Reading, I'm splitting up the PRs to make them more reasonable to review.
This PR updates the version of the Arrow Go library being utilized and implements the conversions from Arrow Schemas to Iceberg Schemas, including name mapping for handling field IDs properly.
Tests are also included for this.