[HUDI-7429] Fixing average record size estimation for delta commits #10763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...ark-client/src/test/java/org/apache/hudi/table/action/commit/TestAverageRecordSizeUtils.java
Outdated
Show resolved
Hide resolved
...i-spark-client/src/main/java/org/apache/hudi/table/action/commit/AverageRecordSizeUtils.java
Show resolved
Hide resolved
vinishjail97
approved these changes
Feb 28, 2024
nsivabalan
force-pushed
the
avgRecSizeEstimate
branch
from
367c1d6
to
95411f5
Compare
4 tasks
the-other-tim-brown
suggested changes
Apr 19, 2024
...i-spark-client/src/main/java/org/apache/hudi/table/action/commit/AverageRecordSizeUtils.java
Outdated
Show resolved
Hide resolved
nsivabalan
force-pushed
the
avgRecSizeEstimate
branch
2 times, most recently
from
9a575fe
to
34ffbbc
Compare
yihua
approved these changes
May 11, 2024
yihua
added a commit
that referenced
this pull request
May 15, 2024
…10763) Co-authored-by: Y Ethan Guo <[email protected]> Co-authored-by: Jonathan Vexler <=>
yihua
added a commit
that referenced
this pull request
May 15, 2024
…10763) Co-authored-by: Y Ethan Guo <[email protected]> Co-authored-by: Jonathan Vexler <=>
yihua
added a commit
that referenced
this pull request
May 15, 2024
…10763) Co-authored-by: Y Ethan Guo <[email protected]> Co-authored-by: Jonathan Vexler <=>
|
Hello, Is there a reason why we think including |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
Avg record size calculation only considers COMMIT actions for now. Fixing it to include replace commits and delta commits as well.
Impact
Fixing avg record size estimation for delta commits and replace commits.
Risk level (write none, low medium or high below)
low
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change
ticket number here and follow the instruction to make
changes to the website.
Contributor's checklist