[HUDI-6089] Handle default insert behaviour to ingest duplicates #10728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wombatu-kun
force-pushed
the
HUDI-6089_duplicate_on_insert_default_true
branch
from
6348547
to
22f8752
Compare
danny0405
reviewed
Feb 24, 2024
| @@ -562,7 +562,7 @@ public class HoodieWriteConfig extends HoodieConfig { | |||
|
|
|||
| public static final ConfigProperty<String> MERGE_ALLOW_DUPLICATE_ON_INSERTS_ENABLE = ConfigProperty | |||
| .key("hoodie.merge.allow.duplicate.on.inserts") | |||
| .defaultValue("false") | |||
| .defaultValue("true") | |||
| .markAdvanced() | |||
There was a problem hiding this comment.
Is there any real use case to illustrate this switch?
There was a problem hiding this comment.
i think there is, as people create tasks and issues: #8451
https://issues.apache.org/jira/browse/HUDI-6089
https://issues.apache.org/jira/browse/HUDI-6346
There was a problem hiding this comment.
Okay, let's rebase with the latest master and make all the tests pass.
There was a problem hiding this comment.
done, PR is ready to merge.
wombatu-kun
force-pushed
the
HUDI-6089_duplicate_on_insert_default_true
branch
from
22f8752
to
11a6e3d
Compare
wombatu-kun
force-pushed
the
HUDI-6089_duplicate_on_insert_default_true
branch
from
11a6e3d
to
6ea9dfe
Compare
wombatu-kun
force-pushed
the
HUDI-6089_duplicate_on_insert_default_true
branch
from
6ea9dfe
to
337a99c
Compare
bvaradar
approved these changes
Mar 2, 2024
|
cc @nsivabalan : this needs update in documentation. |
yihua
pushed a commit
that referenced
this pull request
May 14, 2024
) Co-authored-by: Vova Kolmakov <[email protected]>
yihua
pushed a commit
that referenced
this pull request
May 14, 2024
) Co-authored-by: Vova Kolmakov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
Made default value of "hoodie.merge.allow.duplicate.on.inserts" as True and fixed tests.
Impact
low
Risk level (write none, low medium or high below)
low
Documentation Update
Documentation update is needed as default value of HoodieWriteConfig property "hoodie.merge.allow.duplicate.on.inserts" changed to true
ticket number here and follow the instruction to make
changes to the website.
Contributor's checklist