-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HUDI-6787] Integrate the new file group reader with Hive query engine #10422
Merged
Merged
Changes from all commits
Commits
Show all changes
43 commits
Select commit
Hold shift + click to select a range
aa6e1c2
squash commits
3674390
refactor a bit and add some comments
edad863
make build properly
b764026
fix some of the failing tests
6647869
revert to old impl when schema evolution enabled
b43949b
disable fg reader for stupid test
2bc441f
fix some failing tests
1bcbab8
assigned the ports backwards
6e5fadd
verbose output bundle validation
dc4ac6f
add volume to docker compose
8669cce
need to lowercase the field names omg
fdeea22
don't remove partition if it's listed in the schema
60fe6fa
put partition cols at end of output
ad3f3d3
invert filter
6a77480
support no base file, only log. support read from non-hudi table
51f91c7
disable for skip merge as well
1da1e76
fix non hoodie path read
2b1f172
revert setting precombine
7b45027
fix no meta cols table
16cff40
check if no requested fields
e115fd5
create empty schema properly
211bcb9
check if metadata folder exists
73bedb4
handle mor with no meta fields
3f412a1
disable reader for a test because mor seems to work different
51a47e4
delete partition column from the jobconf if it is written in the file
a8020bd
modify data schema due to partition column madness
25078f3
remove unused import
c225f52
add some comments
069a5ad
don't add partition fields when the data schema doesn't have them
185217d
address review feedback
6d58742
accidently put remove in for loop for combine reader
325a8b7
get building again
a012522
address some review comments
50bd39f
add reviewer suggested change
50a308d
add missing params fg reader
5a33e85
address some comments
18fbd92
Fix post rebase
codope 9487e12
fix hudi table check
codope 2201cb0
Address self feedback
codope b29ff63
Merge branch 'master' into use_fg_reader_hive
33249cc
fix failing test
89a4a8c
Merge branch 'master' into use_fg_reader_hive
e95bcb8
fix failing test
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -476,6 +476,6 @@ public Object get(String key) { | |
} | ||
|
||
public enum HoodieRecordType { | ||
AVRO, SPARK | ||
AVRO, SPARK, HIVE | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, what do you mean by this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://issues.apache.org/jira/browse/HUDI-7610 Delete behavior is inconsistent and imo undefined. This is one of the advantages of unifying all the readers with FGReader is that we can remove the inconsistency between engines.