feat: support filter pushdown for datafusion #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #203 +/- ##
==========================================
- Coverage 91.78% 90.62% -1.17%
==========================================
Files 20 24 +4
Lines 962 1067 +105
==========================================
+ Hits 883 967 +84
- Misses 79 100 +21 ☔ View full report in Codecov by Sentry. |
xushiyan
reviewed
Dec 2, 2024
crates/core/src/table/mod.rs
Outdated
| @@ -194,7 +195,7 @@ impl Table { | |||
| pub async fn get_file_slices_splits( | |||
| &self, | |||
| n: usize, | |||
| filters: &[(&str, &str, &str)], | |||
| filters: &[PartitionFilter], | |||
There was a problem hiding this comment.
we should provide a generic struct for constructing filter, and not limited to PartitionFilter. And let's mark the existing api deprecated in the upcoming release and only remove in a future release
There was a problem hiding this comment.
I made the fixes but I was a little confused how to deprecate this. Should I create another similar function?
xushiyan
reviewed
Dec 2, 2024
xushiyan
reviewed
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added
ExprtoPartitionFilterconversion to pass in filters. Datafusion will pass down all filters for now usingsupports_filters_pushdownand will filter after partition filters.Closes #160.
Steps forward
I noticed the pr was getting a bit big to be reviewed all at once, here are some things that will be worked on afterwards:
PartitionFiltersfor testing, etc.How are the changes test-covered
Added unit tests for all added functionality