Cleanup XML for SelectValues transform #4361
Conversation
| @@ -29,4 +29,12 @@ | |||
| <packaging>jar</packaging> | |||
| <name>Hop Plugins Transforms Select Values</name> | |||
|
|
|||
| <dependencies> | |||
There was a problem hiding this comment.
added this for writing assertions in a comfortable and readable way. Ideally we could introduce it in parent project. Will send a proposal.
| selectValuesMeta | ||
| .getSelectOption() | ||
| .setSelectFields(SelectValueMetaTestFactory.getSelectFields("v", "v2")); | ||
| setup(selectValuesMeta); | ||
| } | ||
|
|
||
| @Test | ||
| public void test() throws Exception { |
There was a problem hiding this comment.
This doesn't pass. I can't actually understand how it's building up the meta object, because apparently, it was empty, previously.
Now, with the new structure I get a IndexOutOfBoundException, which I can't fix without understanding what's the subject under test and how I can put it together.
| @@ -40,9 +40,13 @@ | |||
| public class SelectValuesMetaTest { | |||
There was a problem hiding this comment.
This class should be ok. I've removed a few tests that wouldn't make any sense with the current structure.
Well, the remaining ones maybe neither, but less than the evicted ones. 😄
However the focus of this class was already the SelectFields tab, while the Remove and ChangeMetadata part was skipped over completely.
There was a problem hiding this comment.
Not sure whether I should restore this, as I have no background of the underlying PDI issues...
| @@ -145,6 +137,6 @@ private void executeAndCheck(String locale, String expectedWeekNumber) throws Ex | |||
|
|
|||
| List<Object[]> execute = PipelineTestingUtil.execute(transform, 1, true); | |||
There was a problem hiding this comment.
this is returning a formatted date, rather than the expected number of week. Probably the defaultFormatLocale is not working as expected. Heads up are more than welcome.
xdelox
force-pushed
the
1929-select-values
branch
from
29b61e3
to
90ad000
Compare
Fixes #1929
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
mvn clean install apache-rat:checkto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.git rebase -i.addresses #123), if applicable.To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.