Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Russian keyboard layout #1040

Closed
wants to merge 0 commits into from
Closed

Added Russian keyboard layout #1040

wants to merge 0 commits into from

Conversation

VAGurko
Copy link

@VAGurko VAGurko commented Dec 28, 2024

No description provided.

Copy link
Contributor

@necouchman necouchman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VAGurko : Thank you for contributing this code. There are a couple of things that need addressing outside of the one comment below:

  • All changes need a Jira issue associated with them, which means you'll need to go to our Jira page and request an account. Once that's created you'll need to create a Jira ticket for the request and tag both the Pull Request and the commit messages with that Jira issue. You can see this in action in the other pull requests opened for the project.
  • You have four commit messages, including a merge commit, for what is a relatively minor change. The merge commit needs to be removed, and the other commits should probably just be squashed together.
  • The commit messages need to be meaningful and unique. If you're going to have multiple commits, having them all say, "Added Russian keyboard layout" doesn't help to determine what each commit is actually accomplishing. The commit messages should be descriptive of what is happening in the change, for example: "Added Russian keyboard layout to the RDP client settings."

For more complete guidance on contributing to the project, please see: https://guacamole.apache.org/open-source/.

.gitignore Outdated
Comment on lines 3 to 5
.gigaide/
.idea/
guacamole-client.iml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes should not be included as part of this change. If we need to add entries to .gitignore, those should be handled via a specific Jira issue and pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants