Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GOBBLIN-2166] Add azkaban fields in RMAppSummaryEvent for GoT jobs #4067

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

abhishekmjain
Copy link
Contributor

@abhishekmjain abhishekmjain commented Oct 17, 2024

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

JIRA

Description

  • Here are some details about my PR, including screenshots (if applicable):
    GoT doesn't send applicationTags while submitting yarn app from the launcher GobblinYarnAppLauncher. This PR adds the applicationTags to appSubmissionContext during yarn app submission.

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:
    Tested the change in a local azkaban project

The below query shows azkaban properties populated in RMAppSummaryEvent

select * from service.rmappsummaryevent
  where appid in ('application_1729067421867_143934')
    and datepartition between '2024-10-15' and '2024-10-18'
  limit 1;

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

@abhishekmjain abhishekmjain changed the title [GOBBLIN-2166] GoT must fill in info required for RMAppSummaryEvent fields [GOBBLIN-2166] Add azkaban fields in RMAppSummaryEvent for GoT jobs Oct 17, 2024
@phet phet merged commit e3baf91 into apache:master Oct 21, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants