Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GOBBLIN-2162] Only load added jars in the cache #4062

Merged

Conversation

Will-Lo
Copy link
Contributor

@Will-Lo Will-Lo commented Oct 2, 2024

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

JIRA

Description

  • Here are some details about my PR, including screenshots (if applicable):

When Gobblin launches a YARN app, if the cache is enabled it will load all the jars stored in the cache into the classpath.

This can be problematic as jars that persisted from older versions of jars or other executions may clobber the classpath, adding jars that are not needed or jars that interfere with the current jars.

This PR ensures that only the jars that were intended to be uploaded by the GobblinYarnAppLauncher are the only jars that are loaded into the classpath from the shared cache.

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Copy link
Contributor

@phet phet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just needs a test!

Comment on lines 551 to 552
String containerJars = this.config.hasPath(GobblinYarnConfigurationKeys.CONTAINER_JARS_KEY) ?
this.config.getString(GobblinYarnConfigurationKeys.CONTAINER_JARS_KEY) : "";
Copy link
Contributor

@phet phet Oct 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't we have a getPath or a getString that takes a default?

let's call within a getAppLibJarList(this.config) utility, which would offer far more facile testability

@Will-Lo Will-Lo merged commit 4f60423 into apache:master Oct 21, 2024
6 checks passed
@Will-Lo Will-Lo deleted the ensure-yarn-cache-only-loads-uploaded-jars branch October 21, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants