-
Notifications
You must be signed in to change notification settings - Fork 751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GOBBLIN-2148] Add temporal workflow cancel support #4045
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blazer-007
reviewed
Sep 4, 2024
...mporal/src/main/java/org/apache/gobblin/temporal/joblauncher/GobblinTemporalJobLauncher.java
Show resolved
Hide resolved
...mporal/src/main/java/org/apache/gobblin/temporal/joblauncher/GobblinTemporalJobLauncher.java
Outdated
Show resolved
Hide resolved
abhishekmjain
force-pushed
the
temporal-workflow-cancel
branch
from
September 4, 2024 11:56
dd18b71
to
f3f61d6
Compare
abhishekmjain
force-pushed
the
temporal-workflow-cancel
branch
from
September 5, 2024 06:55
2162167
to
39b48cb
Compare
khandelwal-prateek
suggested changes
Sep 30, 2024
...mporal/src/main/java/org/apache/gobblin/temporal/ddm/launcher/ExecuteGobblinJobLauncher.java
Outdated
Show resolved
Hide resolved
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/joblauncher/GobblinJobLauncher.java
Show resolved
Hide resolved
...mporal/src/main/java/org/apache/gobblin/temporal/joblauncher/GobblinTemporalJobLauncher.java
Show resolved
Hide resolved
...mporal/src/main/java/org/apache/gobblin/temporal/joblauncher/GobblinTemporalJobLauncher.java
Show resolved
Hide resolved
...mporal/src/main/java/org/apache/gobblin/temporal/joblauncher/GobblinTemporalJobLauncher.java
Outdated
Show resolved
Hide resolved
...poral/src/main/java/org/apache/gobblin/temporal/joblauncher/GobblinTemporalJobScheduler.java
Show resolved
Hide resolved
...mporal/src/main/java/org/apache/gobblin/temporal/joblauncher/GobblinTemporalJobLauncher.java
Outdated
Show resolved
Hide resolved
...al/src/test/java/org/apache/gobblin/temporal/joblauncher/GobblinTemporalJobLauncherTest.java
Show resolved
Hide resolved
Will-Lo
reviewed
Oct 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commenting on the PR description here, but 3 seconds for cancellation seems quite aggressive. Is there a way for us to increase this timeout to say, 30 seconds?
Will-Lo
reviewed
Oct 2, 2024
...mporal/src/main/java/org/apache/gobblin/temporal/ddm/launcher/ExecuteGobblinJobLauncher.java
Outdated
Show resolved
Hide resolved
Will-Lo
reviewed
Oct 2, 2024
...mporal/src/main/java/org/apache/gobblin/temporal/joblauncher/GobblinTemporalJobLauncher.java
Show resolved
Hide resolved
Will-Lo
reviewed
Oct 2, 2024
...mporal/src/main/java/org/apache/gobblin/temporal/joblauncher/GobblinTemporalJobLauncher.java
Outdated
Show resolved
Hide resolved
Will-Lo
reviewed
Oct 2, 2024
...mporal/src/main/java/org/apache/gobblin/temporal/joblauncher/GobblinTemporalJobLauncher.java
Outdated
Show resolved
Hide resolved
Will-Lo
reviewed
Oct 2, 2024
...mporal/src/main/java/org/apache/gobblin/temporal/joblauncher/GobblinTemporalJobLauncher.java
Outdated
Show resolved
Hide resolved
Will-Lo
reviewed
Oct 2, 2024
...mporal/src/main/java/org/apache/gobblin/temporal/joblauncher/GobblinTemporalJobLauncher.java
Show resolved
Hide resolved
Will-Lo
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA
Description
Currently, when GaaS Temporal job are cancelled, only the Azkaban job is stopped, which stops the subsequent YARN application. However, the Temporal job that is submitted by the YARN application is not stopped.
As part of this PR, we have implemented the cancel flow which should cancel the Temporal workflow upon cancellation of Azkaban job.
The support for cancellation is added in base class GobblinTemporalJobLauncher. The workflowId is needed for cancellation, thus some changes are made to initialize the workflowId in submitJob, which can then be used for cancellation.
Tests
I have also tested the cancel flow in personal Az project for all 3 cases:
a) If cancellation completes within 3 seconds, successful cancellation of Temporal workflow
b) If cancellation takes more than 3 seconds, termination of Temporal workflow
Commits