Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-36664][Window]Window with offset need deal offset when cal nextTriggerWatermark. #25629

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

xing1mo
Copy link

@xing1mo xing1mo commented Nov 8, 2024

What is the purpose of the change

Fixed the problem of data loss in window with offset.

Brief change log

Passing in window offset when cal nextTriggerWatermark.

Verifying this change

This change added tests and can be verified as follows:

  • Added test that validates that widow data with offset is not lost.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

@flinkbot
Copy link
Collaborator

flinkbot commented Nov 8, 2024

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@xing1mo
Copy link
Author

xing1mo commented Nov 14, 2024

@xuyangzhong Dear xuyang, could you please review it for me when you have some time? Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants